search

RealDebugMonkey / ZeachCobbler

Custom Agario modifications
56 stars 51 forks source link

Misc updates #78

Closed smurfix closed 8 years ago

smurfix commented 8 years ago

Hi, I present you with (a) a client-side protocol update, derived by inspecting the current official client (the first commit), (b) a fix to the mouse click handler (it took to splitting and then shooting, which is not quite what I want), (c) a heap of Javascript cleanup which helped me debug this code (everything else).

Please do take at least the first two commits. All of them would be nice. ;-)

ghost commented 8 years ago

I tested it few mins and its working good for now, but the mousedown handler needs some updates. I forgot that when i was pulling the click to split function. There should be a handler for left & right click, so on both buttons you can have binded some function. I will do that tomorow (If I dont forget :smile:). Also I will look up for all the changes.

RealDebugMonkey commented 8 years ago

I could have sworn I commented on this earlier today, so forgive me if this is a duplicate somehow. The fix looks request looks good -- How did you arrive at protocol changes?

Anyway, I will be merging this in the next day or two, just as soon as I can play with it a little and PepinCZ agrees with the merge.

Sorry for the delay!

RealDebugMonkey commented 8 years ago

Actually, you know what? Let's just do it and see what happens :)

smurfix commented 8 years ago

I simply fed the original code through a jacascript formatter and compared what they now do to what they did when you copied the script. ;-)

I've been running my version for days now and didn't observe any problems.

ghost commented 8 years ago

For me works good too. But where you come to the prococol chnages? Maybe post link? Thanks!

RealDebugMonkey commented 8 years ago

The Javascript is strong with this one. I did that myself to write this script and it sucks

That's why I haven't done the overhaul/update yet. Since you've already sort of done the work @smurfix were there any other significant changes? Could I actually be fortunate enough that a complete update not needed?

smurfix commented 8 years ago

I didn't notice any; however I only looked at the handler for packet type 16 really close.

I'll probably check the thing again during the next few days or so.