RealEnder / redmine_auditlog

Provides full auditlog for user actions in Redmine instance
GNU General Public License v3.0
3 stars 5 forks source link

Activate auditlog for users and groups in Redmine 4.x.x #6

Closed jonashellmann closed 2 years ago

jonashellmann commented 2 years ago

It is necessary to also include sub classes that extend the classes User and Group. This helped me to get rid of the error on startup. The reason for this can probably be found here: https://github.com/rails/rails/blob/26521331e5923a0c50fa50984d2f924e5f26c50b/activesupport/lib/active_support/callbacks.rb#L625 where there is an iteration over all subclasses of the class that is mentioned in init.rb.

RealEnder commented 2 years ago

Thank you very much for looking into this! Currently can't test it, but will merge the PR and will amend if internal tests show something weird. Have you had an opportunity to test with redmine 5?

jonashellmann commented 2 years ago

Unfortunately I was not able to test these changes with Redmine 5. If I have any new information in this regard, I'll add another comment to this PR.

jonashellmann commented 2 years ago

I just wanted to try if my changes also work with Redmine 5 but it seems that this plugin is not ready for Redmine 5 in general (see https://github.com/RealEnder/redmine_auditlog/issues/5). There seems to be a problem with the zeitwerk gem used by Ruby.

san199332 commented 1 year ago

I just wanted to try if my changes also work with Redmine 5 but it seems that this plugin is not ready for Redmine 5 in general (see #5). There seems to be a problem with the zeitwerk gem used by Ruby.

This plugin works with redmine 5, see my fork https://github.com/san199332/redmine_auditlog