RealEnder / signTextLSF

WebExtension implementing crypto.signText() over LSF
1 stars 0 forks source link

Rework extension to be cross-browser #11

Closed user890104 closed 6 years ago

user890104 commented 7 years ago

Using this guide: https://blog.codeship.com/webextensions-101/ It uses node/npm for building, Mozilla's webextension-polyfill for cross-browser compatibility and Mozilla's web-ext for testing and packaging.

user890104 commented 7 years ago

This will support the following browsers from the same codebase:

Firefox supports both browser. and chrome..

stamo commented 7 years ago

I've tried webextension-polyfill and it is working like magic. I've installed the same extension in Chrome, Firefox and Edge and I was able to sign text. The only problem is with HTTPS. Firefox and Chrome are ok with localhost.uslugi.io, but Edge can not find it.

stamo commented 7 years ago

I've merged changes and now there is a problem with Edge.

The manifest file is broken. Edge does not like the permissions section of manifest.json

RealEnder commented 7 years ago

@stamo please try with jnlp from here for SOP issue Permissions section was just extended, @user890104 added it for Opera. Edge supports permission section and redirects to MDN. Maybe we should add /* at URLs end?

stamo commented 7 years ago

@RealEnder /* solved the issue with Edge manifest

stamo commented 7 years ago

@RealEnder Yes Edge is working with HTTPS with this new JNLP

user890104 commented 7 years ago

I need assitance with installation on Edge, it does not work for me. I can provide remote access my testing Win 10 VM. Attaching a screenshot of the exception. image

stamo commented 6 years ago

Extension is working properly on Chrome/Firefox/Edge/Opera browsers. Unfortunately Edge does not support background-color for badges, so we can't use red or green badge to indicate presence of LSF

stamo commented 6 years ago

added text to badge, ok if LSF is available and n/a if not, so we do not depend on color code. This resolves cross browser compatibility