search

RealFaviconGenerator / realfavicongenerator

Generate favicon for all major platforms
501 stars 24 forks source link

Windows icon display broken in "featured favicons" #277

Open BenWiederhake opened 7 years ago

BenWiederhake commented 7 years ago

For some reasons, this preview displays the IE-icon in place of "our" icon: https://realfavicongenerator.net/featured_favicons/p1athnlpctkp6mo61s28utt3596

None of the files I received in favicons.zip are like this, so I suppose it's just a minor slip-up in the preview code. Still, it scared me a bit :)

EDIT: Maybe some proof might help, in case it gets correctly displayed for everyone else: house-of-ie

I intentionally phrased the title a bit like #257, although these seem unrelated.

BenWiederhake commented 7 years ago

After using the checker tool: Argh, looks like I took a wrong turn when walking through all the options. Sorry, my bad, the preview is correct.

BenWiederhake commented 7 years ago

Actually, no, I don't understand this.

<meta name="msapplication-TileColor" content="#00a300">
<meta name="msapplication-TileImage" content="/mstile-144x144.png">

If this is part of the HTML page, and all other icons of the icon-block get recognized, then why doesn't this work?

phbernard commented 7 years ago

Weird. If your site is live, could you give me its URL for review? If you don't want to disclose it here, you can also mail it to me at contact@realfavicongenerator.net

BenWiederhake commented 7 years ago

I just pushed it, it's currently "live" (not in production yet, but live enough) at https://houseoftweets.github.io/

I just ran your checker on it again, at it recognizes:

[green] The Browser Configuration file is present [red] There is no tile icon for Windows This is somewhat strange, because I think it should be precisely the other way around: there is no dedicated Browser Configuration file, but there is a tile icone for Windows: https://houseoftweets.github.io/mstile-144x144.png

Note that this issue is not critical for this project, so if you can't figure it out and aren't interested, just close this. Either way, I'm very willing to help.