search

RealGeeks / lab_tech

Rails engine for using GitHub's 'Scientist' library with ActiveRecord, for those of us not operating apps at ROFLscale
MIT License
65 stars 15 forks source link

Rails 7.0 support? #42

Open mikdiet opened 2 years ago

mikdiet commented 2 years ago

Current gemspec doesn't allow Rails 7.0 https://github.com/RealGeeks/lab_tech/blob/main/lab_tech.gemspec#L20

It blocks our 6.1 app from upgrading to Rails 7.0.

dhnaranjo commented 2 years ago

I'm running Rails 7 with my fork. I didn't submit a PR because I didn't really test it, it worked in my very narrow set of needs at that moment, and it required one substantive change that I honestly didn't understand, so I'd want to set up like, a test matrix with Rails 5, 6, n 7 to make sure that change didn't influence earliers.

But you know. Feel free to fork mine and get to work. Probably don't refer to my actual repo because I may well delete it if I feel like it.

geeksam commented 1 year ago

Sorry, I left Real Geeks and no longer have commit privileges to this repo. Pinging @larslevie @kevin1024 @LupineDev @Sparkmasterflex

anaulin commented 10 months ago

For anyone looking into this issue: Earlier this year @northeastprince and @Sparkmasterflex both committed changes to main addressing dependency upgrades and compatibility issues. The gemspec restriction that was preventing using this gem with Rails 7 no longer exists.

There hasn't been a recent release of the gem, however, so in order to benefit from these updates you'll need to point at the main branch of the repo.