RealMegaMinds / ActionInventoryMod

A fabric Minecraft mod that allows the creation of special inventories that can do certain things when items are clicked.
MIT License
17 stars 3 forks source link

Some placeholder apis work abnormally #13

Closed half-nothing closed 1 year ago

half-nothing commented 1 year ago

Hello,I have a little problem when using your mod. This placeholder api does not work, what happened? image image So, what can I do to solve this problem? image

mod version: actioninventory-3.4.1+1.20 placeholder version: placeholder-api-2.1.1+1.20

All right, I look your commit 44ae607 It looks like you didn't replace placeholderApi for customNbt, just replace for customName?

Hoid2 commented 1 year ago

Currently placeholder api is only used for:

But I'll add support for the custom nbt too.

half-nothing commented 1 year ago

Currently placeholder api is only used for:

  • titles
  • item name and lore
  • GiveAction items
  • Messages and commands

But I'll add support for the custom nbt too.

Thank you for your explanation. Btw, may I clone your repositories to implement this function, because I am free because time is tight

Hoid2 commented 1 year ago

Try this version https://modrinth.com/mod/actioninventory/version/3.5.0+1.20.1

half-nothing commented 1 year ago

Unfortunately, it does not work well. image image image image

Hoid2 commented 1 year ago

Were there any errors?

half-nothing commented 1 year ago

Were there any errors?

Nothing.

Hoid2 commented 1 year ago

It appears that the name is correctly changing, just for some reason the texture isn't. It may take me a little while to figure it out.

Hoid2 commented 1 year ago

I think I figured it out. Could you test this version and let me know? actioninventory-3.5.0+1.20.1-test.jar

half-nothing commented 1 year ago

I think I figured it out. Could you test this version and let me know? actioninventory-3.5.0+1.20.1-test.jar

Can you send it again?The link timed out.

Hoid2 commented 1 year ago

You will have to unzip it. Github doesn't allow raw jar files. actioninventory-3.5.0+1.20.1-test.zip

half-nothing commented 1 year ago

You will have to unzip it. Github doesn't allow raw jar files. actioninventory-3.5.0+1.20.1-test.zip

It works well! Thanks a lot.

Hoid2 commented 1 year ago

"official" version: https://modrinth.com/mod/actioninventory/version/3.5.1+1.20.1