Find below a couple of things I would like to highlight (numbers for easier reference only):
I introduced the enqueued_at field as required and setting it to timezone.now() during the migration. As this only causes wrong enqueue times and we'll most likely squash migration pre-v1, I see no issues with that. Anything wrong with that reasoning?
I set the finished_at time of the DummyBackend to None. It is the intended behaviour of the DummyBackend to accept tasks, but not complete them by itself, correct?
Do you think we should add a test for the TaskResult.(a)refresh methods through this PR, which asserts that the status, finished_at and result returned by the backend are actually used to update the TaskResult? That tests seems rather elaborate, while providing only little value. What do you think?
Find below a couple of things I would like to highlight (numbers for easier reference only):
enqueued_atfield as required and setting it totimezone.now()during the migration. As this only causes wrong enqueue times and we'll most likely squash migration pre-v1, I see no issues with that. Anything wrong with that reasoning?finished_attime of the DummyBackend to None. It is the intended behaviour of the DummyBackend to accept tasks, but not complete them by itself, correct?TaskResult.(a)refreshmethods through this PR, which asserts that thestatus,finished_atandresultreturned by the backend are actually used to update theTaskResult? That tests seems rather elaborate, while providing only little value. What do you think?