search

RealOrangeOne / django-tasks

A reference implementation and backport of background workers and tasks in Django
https://pypi.org/project/django-tasks/
BSD 3-Clause "New" or "Revised" License
211 stars 13 forks source link

Remove close method #61

Closed knyghty closed 1 week ago

knyghty commented 1 week ago

Fixes #27

The issue also mentions changing the docstring of the constructor, but I don't see any such docstring, is that just out of date or am I missing something?

RealOrangeOne commented 1 week ago

I don't see any such docstring

I think that's from the DEP - safe to ignore.

You'll also need to remove the signal (which is why CI is complaining):

https://github.com/RealOrangeOne/django-tasks/blob/b91b8a9ab4767d24a8812e23f45055ec694b9014/django_tasks/__init__.py#L74-L75

knyghty commented 1 week ago

You'll also need to remove the signal (which is why CI is complaining):

@RealOrangeOne ah, thanks, I saw this but thought it unrelated. Apparently not :)

I am a bit unclear still if the entire signal_handlers.py file and the function therein can also be removed, not really sure what is happening here.

I pushed the change without removing this.

RealOrangeOne commented 1 week ago

I am a bit unclear still if the entire signal_handlers.py file and the function therein can also be removed

That needs to remain. The signal left in there helps with tests when using @override_settings