search

RealOrangeOne / react-native-busy-indicator

A simple, event controlled, busy indicator for react-native
MIT License
94 stars 41 forks source link

使用prop-types定义属性,避免在0.49.0上崩溃 #21

Closed chenmo230 closed 6 years ago

joshhornby commented 6 years ago

Can this be merged?

RealOrangeOne commented 6 years ago

@joshhornby Unfortunately not, until my requested changes are made anyway

joshhornby commented 6 years ago

@RealOrangeOne I've made the changes on a new PR https://github.com/RealOrangeOne/react-native-busy-indicator/pull/22

joshhornby commented 6 years ago

Actually it looks like this PR is doing it correctly:

https://github.com/facebook/prop-types#how-to-depend-on-this-package https://github.com/facebook/prop-types/issues/44

So I believe you can close my PR and merge this one.

joshhornby commented 6 years ago

I've tested and this is working correctly.

RealOrangeOne commented 6 years ago

Ohh, I didn't know that, good to know! Just need the tests to pass now (I assume it's just the linter)

joshhornby commented 6 years ago

@RealOrangeOne All tests are passing for this PR 👍

RealOrangeOne commented 6 years ago

Oh, I read the wrong X, damn you GitHub!

joshhornby commented 6 years ago

Thanks for merging, can you cut a new release as well? @RealOrangeOne