search

RealOrangeOne / react-native-mock

A fully mocked and test-friendly version of react native (maintainers wanted)
MIT License
571 stars 153 forks source link

Incompatibility with React 15.4.0 #111

Closed joemckie closed 7 years ago

joemckie commented 7 years ago

Your dependency on react-addons-perf is breaking with React 15.4.0.

Can this be updated?

RealOrangeOne commented 7 years ago

Yes, that should be a very simple fix!

joemckie commented 7 years ago

@RealOrangeOne I'm taking a look into a PR now. Is there a reason why the versions are explicitly required using = rather than ^?

RealOrangeOne commented 7 years ago

for devDependancies yes, it allows for more reproducable tests. For the main dependancies no, Think I messed up a find/replace

gaearon commented 7 years ago

I'd recommend using Jest for testing React Native instead. That's what we use at FB, and we maintain it. (Never mind my comment, wrong thread)

Richard-Cao commented 7 years ago

The same error:

Error: Cannot find module 'react/lib/ReactPerf'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/richardcao/workspace/reading/node_modules/react-addons-perf/index.js:1:18)

Version:

joemckie commented 7 years ago

@Richard-Cao check out the PR (#114). Looks like RN has a stable 0.38.0 release now so we can try and get this fixed!