search

RealOrangeOne / react-native-mock

A fully mocked and test-friendly version of react native (maintainers wanted)
MIT License
571 stars 153 forks source link

Add React 15.4.0 compatibility #114

Closed joemckie closed 7 years ago

joemckie commented 7 years ago

Since React 15.4.0, react-addons-perf looks to react-dom. This PR updates dependency versions and removes the react-addons-linked-state dependency, which is now deprecated.

Fixes #111.

RealOrangeOne commented 7 years ago

Thanks for doing this (and catching the linked-state deprication!). Not sure what's up with the tests failing. Am having a look into that now

joemckie commented 7 years ago

@RealOrangeOne no problem! I'm not sure what's up with the tests either. Looks like it's only on v4, but looks like a problem that's been going on for a while (look at the previous build logs).

RealOrangeOne commented 7 years ago

seems the reason the tests are failing is because react-native doesnt yet support react@15.4.0, so merging this would likely break the install for a lot of people

joemckie commented 7 years ago

@RealOrangeOne looks like you might be right.

v0.38.0-rc.0 seems to have support for v15.4.0, and RN has a fortnightly release cycle, so I'd expect compatibility to be available in a few days' time.

joemckie commented 7 years ago

@RealOrangeOne : v0.38.0

joemckie commented 7 years ago

Hey FYI @RealOrangeOne the NPM package still needs version bumping to get this fix out :)

messense commented 7 years ago

Please release a new version on NPM. Thanks @RealOrangeOne

joemckie commented 7 years ago

Yup. Currently blocking my project and I'm having to workaround right now!

RealOrangeOne commented 7 years ago

Released v0.2.9