search

RealOrangeOne / react-native-mock

A fully mocked and test-friendly version of react native (maintainers wanted)
MIT License
570 stars 153 forks source link

Missing support for percentage widths #135

Open fadookie opened 7 years ago

fadookie commented 7 years ago

React Native has recently added support for percentage widths.

Tests now fail props validation if a react-native-mock component is passed a percentage width string instead of a number:

Error: Warning: Failed prop type: Invalid prop `style.width` of type `string` supplied to `View`, expected `number`.
RealOrangeOne commented 7 years ago

Ooh, that's a nice improvement. I'm kinda suprised proptype failures cause tests to fail though, but hey it is an actual error i guess.

I plan to spend a large amount of time upgrading the project in the coming weeks, i'll make sure to add this to the list of things to check!