search

RealOrangeOne / react-native-mock

A fully mocked and test-friendly version of react native (maintainers wanted)
MIT License
570 stars 153 forks source link

Make react-dom a peer dependency. #143

Closed miracle2k closed 6 years ago

miracle2k commented 6 years ago

My setup is a bit unusual, but I ran into trouble due to two copies of react-dom. All three of them should be peer dependences, since react-native-mock shouldn't really use it's own copy.

RealOrangeOne commented 6 years ago

I agree, however this causes issues with the tests, hence travis is failing.

I think the nicest solution would be to add it as a dev dependency too? So npm actually installs it

miracle2k commented 6 years ago

I see, makes sense.

In my case, I have a ./web directory next to ./ios where I have react-native-web with it's own react-dom copy. But I'll have to figure out how to solve this on my own then.