search

RealOrangeOne / react-native-mock

A fully mocked and test-friendly version of react native (maintainers wanted)
MIT License
570 stars 153 forks source link

Imported PropTypes from prop-types everywhere #149

Closed sdeleon28 closed 6 years ago

sdeleon28 commented 6 years ago

Changed PropTypes imports to use prop-types package instead of React's bundled PropTypes. I had experienced this bug https://github.com/RealOrangeOne/react-native-mock/issues/139, then fixed it using the latest master but I got a similar one with shape instead of number. This fixes that.

Note: Modifies version numbers in package.json in order to resolve peerDependencies properly.

sdeleon28 commented 6 years ago

Don't merge this yet. It causes createClass errors.

sdeleon28 commented 6 years ago

I'm working on changing the codebase to use ES6 classes instead of createClass. Should be ready next week.

Parasrah commented 6 years ago

@sdeleon28 any timeline on this?

sdeleon28 commented 6 years ago

@Right2Drive I continued this work in #150, but hit another roadblock and I actually left this hanging because it wasn't the root of the problem I was facing (which I can't even recall - sorry). I don't have the bandwidth to address this right now but feel free to continue the work I did on that branch, but have in mind it may not even be the right thing to do: There seem to be a bunch of PRs on a rewrite branch, so maybe my changes don't even make sense anymore. Perhaps @RealOrangeOne can shed some light on this?