search

RealOrangeOne / react-native-mock

A fully mocked and test-friendly version of react native (maintainers wanted)
MIT License
571 stars 153 forks source link

Add ActivityIndicator #74

Closed varmais closed 8 years ago

varmais commented 8 years ago

Implements mock for ActivityIndicator.

RealOrangeOne commented 8 years ago

Nice mock! I'm not to familiar with the proptypes, but is there a way we can validate the colour, instead of checking it's just a string?

varmais commented 8 years ago

Good catch! I updated the pull request so that it uses ColorPropType module to validate the color prop.

It seems that the ColorPropType might also need some additions to make it match RN ColorTypeProp but I guess that is a concern for separate PR.

RealOrangeOne commented 8 years ago

Definately something for another PR, nice work though. Merging!