search

RealOrangeOne / react-native-mock

A fully mocked and test-friendly version of react native (maintainers wanted)
MIT License
571 stars 153 forks source link

Publish new version to npm #83

Closed vikeri closed 8 years ago

vikeri commented 8 years ago

Just wondering when the next version will be published to npm? Since I'll be using this with Travis I'd prefer not to have to pull master. Using NavigationExperimental so I need the newer version.

sibelius commented 8 years ago

u can specify a commit number instead of master

vikeri commented 8 years ago

@sibelius I did that but it failed since the folder build generated from npm run build was not present. I had to clone it and run npm link which then built the build-folder.

sibelius commented 8 years ago

I though prepublish script https://github.com/lelandrichardson/react-native-mock/blob/master/package.json#L7 would handle the generation of build

we need to fix this to enable install from github directly

RealOrangeOne commented 8 years ago

I have been thinking of some kind of react-native@next that would auto deploy from travis. But yes, I shall push out a new release later today

sibelius commented 8 years ago

@RealOrangeOne what about install directly from github?

RealOrangeOne commented 8 years ago

that would work, but currently the app will require a build step unless youre using something like babel-node.

mortik commented 8 years ago

Why not just add the build dir to the repo?

RealOrangeOne commented 8 years ago

because commiting the built source is a nightmare for PR review, and generally a bad idea.

mortik commented 8 years ago

I would like to disaggree ^^ but thats only my opinion. An automated build step and push to npm after the ci is green seems to be the solution then ;)

RealOrangeOne commented 8 years ago

Version 0.2.6 has been released. Will be working on an 'unstable' release schedule soon! Closing this issue for now!