search

RealOrangeOne / react-native-mock

A fully mocked and test-friendly version of react native (maintainers wanted)
MIT License
571 stars 153 forks source link

fix propType warning from react 15.3.0 #94

Closed evollu closed 8 years ago

evollu commented 8 years ago

fix #91

RealOrangeOne commented 8 years ago

Does this really fix the problem? I'm still seeing a direct call?

evollu commented 8 years ago

from official document https://facebook.github.io/react/warnings/dont-call-proptypes.html#fixing-the-false-positive-in-third-party-proptypes

dlahyani commented 8 years ago

@RealOrangeOne this LGTM, as @evollu mentioned this is the suggested fix by Facebook.

We would love to see this merged soon. This is crucial for working with RN 0.33 and, RN 0.33 is required for building with Xcode 8. LMK if I can help somehow to push this.

Thanks.

RealOrangeOne commented 8 years ago

Looking at that documentation, looks fine to me. Merging

dlahyani commented 8 years ago

Thanks guys. What's the process for publishing a new version to npm?

RealOrangeOne commented 8 years ago

very much manual, and usually only when theres a couple of changes. Hopefully i'll do a release early next week