RealOrangeOne / zoloto

A fiducial marker system powered by OpenCV - Supports ArUco and April
https://zoloto.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
13 stars 7 forks source link

Don't pass detector params as argument #233

Closed RealOrangeOne closed 3 years ago

RealOrangeOne commented 4 years ago

Use the super calling pattern, which makes much more sense here.

Lays the foundation to make https://github.com/RealOrangeOne/zoloto/issues/226 much easier.

trickeydan commented 4 years ago

Why not use a property here?

RealOrangeOne commented 4 years ago

Because the idea is you can intercept and change these as needed. Only really like using properties when you're doing funky logic to find a thing, rather than construct it.