search

RealOrangeOne / zoloto

A fiducial marker system powered by OpenCV - Supports ArUco and April
https://zoloto.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
13 stars 7 forks source link

Don't force distance to be an `int` #305

Open RealOrangeOne opened 1 year ago

RealOrangeOne commented 1 year ago

Currently, the distance is required to be an int. Depending on what unit is used for measurements, this isn't always true. Changing to a float not only allows fractional distances, but by extension improves precision.

PeterJCLaw commented 1 year ago

Note that there are quite a few PRs in flight which change a lot of the coordinates stuff, so work on this is likely to conflict with them.

PeterJCLaw commented 1 year ago

A related and possibly desirable change may be to allow the specification of marker sizes as float, so that a more sensible unit can be used (currently consumers tend towards using millimetres due to the int limitation).