RealRTTV / chatcalc

a port of chatcalc to 1.19-1.20
Mozilla Public License 2.0
11 stars 5 forks source link

Pressing tab after a space inserts `NaN` instead of opening or accepting suggestions #2

Closed hibiii closed 1 year ago

hibiii commented 1 year ago

Steps to reproduce:

Expected behavior: If there isn't an expression, then normal tab behavior: search usernames if not a chat message, accept command suggestions, etc.

Observed behavior: NaN is placed in the chat input box instead. This is most apparent when using a command, where muscle memory might make you accidentally insert /setblock NaN NaN NaN chest.

Note: I presume it's seeing an empty expression, thus taking precedence over vanilla mechanics, and evaluating it. This does not happen if there's a non-empty non-expression.

RealRTTV commented 1 year ago

im so sorry, i somehow never saw this, fixing it asap

RealRTTV commented 1 year ago

ok, seems that I fixed it a while ago, I'm so so so so so so sorry I never saw this. ♥ ♥ ♥

RealRTTV commented 1 year ago

https://github.com/RealRTTV/chatcalc/commit/023fc0c3a820bacdee13a26266723dce212e6dc3