RealRaven2000 / FiltaQuilla

Adds many new mail filter actions to Thunderbird
http://quickfilters.quickfolders.org/filtaquilla.html
GNU General Public License v3.0
87 stars 15 forks source link

Folder Name Condition issue #10

Closed El-Pazzo closed 8 months ago

El-Pazzo commented 5 years ago

Hi, at least for German, Folder name (Verzeichnisname) does not work anymore. Within an existing filter the line with that filter is greyed out. If you try to add it via dropdown, Verzeichnisname does not show up as an option.

regards, Pascal

RealRaven2000 commented 5 years ago

Please check your FiltaQuilla options - is the option selected in "Suchbegriffe"?

I was able to define it from here. Filter bearbeiten I will upload a test version to my quickFIlters site shortly.

El-Pazzo commented 5 years ago

Hi, Yes, I checked that several times. For some reason at home the addon is in English and there it works fine. Only in the office where the addon is in German (for whatever reason).

regards, Pascal

RealRaven2000 commented 5 years ago

You could check Javascript error console (CTRL+SHIFT+J) when opening the edit filter dialog. Which version of Thunderbird are you running?

RealRaven2000 commented 5 years ago

Try the latest version from here, as well please: http://downloads.mozdev.org/quickfilters/FiltaQuilla-1.5pre62.xpi (Note, you can enabled the [x] debug option on the support tab for more info; I can use this to add more logging to the error console for your case later)

El-Pazzo commented 5 years ago

latest version I'll only be able to check it on Monday.

El-Pazzo commented 5 years ago

Hi RealRaven,

test version does not have any impact. Verzeichnisname is still missing in filter drop down and for existing filters Verzeichnisname is greyed out.

Javascript console does not contain anything about filtaquilla.

RealRaven2000 commented 5 years ago

weird - any errors when you open the edit filter rules dialog? check the troubleshooting guide and console² here: http://quickfolders.org/support.html (If you configure console² for xul, chrome + JS errors, you may see more)

El-Pazzo commented 5 years ago

I now get an xml error:

Mon Apr 01 2019 14:46:37 Warnung: Trying to re-register CID '{f2809396-1cd1-12b2-841b-8e15f007c699}' already registered by jar:file:///C:/Users/Translating-IT/AppData/Roaming/Thunderbird/Profiles/p90zbpcy.default/extensions/junquilla@mesquilla.com.xpi!/components/inheritPane-service.js. Quelldatei: jar:file:///C:/Users/Translating-IT/AppData/Roaming/Thunderbird/Profiles/p90zbpcy.default/extensions/filtaquilla@mesquilla.com.xpi!/chrome.manifest Zeile: 14

RealRaven2000 commented 5 years ago

I suggest uninstalling filtaquilla and resetting the config string mesquillaInheritedProperties, then install again., not sure what's happening with the registration of that UID, I haven't changed anything there

RealRaven2000 commented 5 years ago

I suggest uninstalling filtaquilla and resetting the config string mesquillaInheritedProperties, then install again., not sure what's happening with the registration of that UID, I haven't changed anything there

El-Pazzo commented 5 years ago

Hi RealRaven, How can I reset the properties?

El-Pazzo commented 5 years ago

found it in about:config

that didn't help either. How can I set filtaquilla to use English as language? Maybe that will help.

RealRaven2000 commented 5 years ago

You can only set your whole Thunderbird to English. Download the English Language pack and enable it: https://ftp.mozilla.org/pub/thunderbird/releases/60.6.1/win32/xpi/en-US.xpi in about:config, set intl.locale.requested = en-US Thunderbird will then use the english locales of all Add-ons (where available) But i am doubtful it will change anything it's not an error caused by locale strings...

El-Pazzo commented 5 years ago

was worth a try, but you were right. It did not change anything

RealRaven2000 commented 5 years ago

I answered a private email from you, but it bounced back with "Message rejected". Can you provide an alternative email to answer to?

Alternatively here is the text

Would it be possible to create an addon that automatically adds a certain text to the email address of To-field (and optionally CC and BCC (both CC and BCC being activated via a box in settings if needed)) if user clicks on reply, reply to all or forward?

what exactly did you have in mind? A text that is added to every address when you type a new email? or just another email address added? Partly, SmartTemplate⁴ can do similar stuff, have a look at this:

http://smarttemplate4.mozdev.org/premium.html#headerManipulation

currently you could have a look at the following the functions:

%header.append(to,"text")% = Append Address to to
%header.delete(to,"text")% = remove address from to (I haven't tested this case)
%header.set(to,"abc@de.com")% = Replace recipient with email address

maybe the can be extended in some useful way? Also check out my YouTube channel for some videos on how to use SmartTemplate⁴: https://youtu.be/Iah85SdtqNE

Here is a list of introductory videos for SmartTemplate⁴: https://www.youtube.com/watch?v=Rk-T465fkEw&list=PLApv7QYQO9nQ2Jn9zmfh4-RS87h6Qu3wW

writing a new Add-on would take a lot of time, so I am not currently in a position to quote you a price on this (but it would take quite a few days to write one from scratch) - so I am more inclined to look at how my existing Add-ons might be usefully modified if the functionality was a matching enhancement for it. SmartTemplate⁴ might just be the right Add-on to do this, depending on what exactly you have in mind.

Another Add-on of mine (QuickFolders) has an advanced "per-folder" setting where you can prefill the from and to addresses when you write a new email from that folder:

https://i.imgur.com/74Ov1Cs.png

(note this is a setting in a QuickFolders tab, pointing to a folder called SmartTemplates, but it is not functionality of SmartTemplate⁴ - it's a QuickFolders Pro setting) - that may be another candidate for doing something like you have in mind. Per folder may be even more useful.

El-Pazzo commented 5 years ago

Hi,

I guess it has to do with the gmail address. We get so much spam from gmail (and none of our clients uses gmail address but company domains) that our admins decided to reject gmail addresses for all our mail servers. I just added an exception for your address but I'm not sure whether whitelist goes before blacklist. :(

I started playing around with SmartTemplate4 a bit but could not yet achieve what I need:

If I hit reply address a.b@mailprovider.com in from field should become a.b@mailprovider.com.sometext.com in to field of mail to send.

I need this for some online solution I use which needs some text appended to its mail address whenever I reply from a specific account and it's quite nagging to have to append it manually everytime. Furthermore if you write a few hundred mails per week you tend to forget to add it every time as not all accounts need this.

so maybe something like %header.set(to,"%to(mail)%.sometext.com")% would help me

El-Pazzo commented 5 years ago

Hi RealRaven,

It's getting stranger every day. ;)

Today I saw that the option Folder name (Verzeichnisname) does not work for only a few filters. For others it works fine and it shows up in the dropdown list. If I clone the faulty filters and save them, Folder name then works like a charm and can also be selected in the dropdown for these filters.

regards, Pascal

RealRaven2000 commented 5 years ago

If you haven't yet, can you try installing my Add-on quickFilters and the "Debug" button (green bug) on the filters list? This fixes issues with filters that do only run manually. (may be worth a shot) https://i.imgur.com/VYX3xoK.png

El-Pazzo commented 5 years ago

as the filter now work due to the trick described above, I cannot get any further debugging info with this tool, but I'll keep it for future usa.

haka61 commented 4 years ago

Hi, I have TB 68.4.1 32-Bit and Filta Quilla 2.0, German Versions. I tried to detach attachements as shown below. grafik For every attachement the line in the protocol ends with "Anhänge speichern in" but no folder name. The attachement extractor works fine.

Regards haka61

RealRaven2000 commented 4 years ago

You can enable debug mode to see if there is any info in the javascript error console.

To enable logging, open FQ settings on the "About FiltaQuilla / Help" tab and check the Debug box:

image

To view the log open Tools / Developer Tools / Error Console (Ctrl+Shift+J). (Extras / Entwickler Werkzeuge / Fehlerkonsole). I advise resetting all output before you carry out the filter operation so you get a cleaner log.

haka61 commented 4 years ago

Hi RealRaven, thank you for the tip. In the error console Iget now:

FiltaQuilla 13:37:40.250 [390634 ms]
saveAttachment() - target directory exists: C:\Kirrung FiltaQuilla.saveAttachment - converting message headers failed. Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgMessageService.streamMessage] uncaught exception: 2147746065 autosync.jsm:251:30

and in the filter protocol: [20.01.2020, 13:37:40] Filter "Fotoabtrennung" auf die Nachricht web51p1@alinso.de - SECACAM am 20.01.2020, 13:37:42 angewendet Anhänge speichern in

but the attachements are not stored in the target directory.

TIA haka61

RealRaven2000 commented 4 years ago

FiltaQuilla 13:37:40.250 [390634 ms] saveAttachment() - target directory exists: C:\Kirrung FiltaQuilla.saveAttachment - converting message headers failed. Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgMessageService.streamMessage]

thanks. so that 0x8000400 is a common error that can occur in lots of cases - it's thrown by the underlying Thunderbird code, so there is not much I can do about it, try running the filter after junk qualification.

haka61 commented 4 years ago

thanks. But it works fine, if I start the filter manually as shown below. grafik

RealRaven2000 commented 4 years ago

thanks. But it works fine, if I start the filter manually as shown below.

That points to a bug in Thunderbird. FiltaQuilla does the same thing, it streams the attachment from the body using an internal Thunderbird command. I think it's obviously just dangerous during/after "get mail" - my guess is it mainly affects IMAP Inboxes. It is possible that the message is just not in a "ready state" to be streamed yet, even if you have selected the option "[x] Keep messages in all folders" in the Syunchronizingation & Storage settings tab:

image

Also there is some positive influence on the attachment stability using the option to run filters after Junk Classification, which also points to a timing problem: image

also let's focus at one thing at a time, attachments are discussed in issue #4

haka61 commented 4 years ago

thanks. I had all Options like you showed them. I think, you are right, it's a synchronisation problem.

RealRaven2000 commented 8 months ago

I am closing the issue for now, feel free to reopen if it is still a problem in 115.