search

RealRaven2000 / FiltaQuilla

Adds many new mail filter actions to Thunderbird
http://quickfilters.quickfolders.org/filtaquilla.html
GNU General Public License v3.0
88 stars 17 forks source link

Make FiltaQuilla compatible with Thunderbird 91 #111

Closed RealRaven2000 closed 2 years ago

RealRaven2000 commented 3 years ago

I have made a head start with the new body regexp function in TB91, which seems to work better using the new MimeParser.extractMimeMsg() function - latest working code was committed earlier this morning. I noticed that on installation / activation the Tonequilla sound files are not extracted to the extensions\filtaquilla subfolder in the profile (it it possible that it already is forbidden, I need to find out).

RealRaven2000 commented 3 years ago

Fixed the sound issue, apparently Ci.nsILoadInfo.SEC_REQUIRE_SAME_ORIGIN_DATA_INHERITS was removed, I replaced it with Ci.nsILoadInfo.SEC_REQUIRE_SAME_ORIGIN_INHERITS_SEC_CONTEXT.

Test version: filtaquilla-3.2pre52.zip

this should copy all relevant sounds when installed / activated, if they don't already exist at the target location.

RealRaven2000 commented 3 years ago

All actions stopped working because the apply() function custom actions for has to now reimplemented (with slightly different 1st parameter) as applyAction(). I wrote backwards-compatible shim code. Test version:

filtaquilla-3.2pre56.zip

(For installation, as always download the zip file and then drag that into Thunderbird Add-ons Manager).

RealRaven2000 commented 3 years ago

Latest version. this has some performance improvements (and should avoid false positives) for regexp match in body, see detail at #75.

filtaquilla-3.2pre86.zip

(For installation, as always download the zip file and then drag that into Thunderbird Add-ons Manager).

mahakala commented 3 years ago

unfortunately, regex is still not available as a condition in thunderbird 91.0.2 for filters. after installation there where serval "nul" entries in the menu, after restart they where gone.

RealRaven2000 commented 3 years ago

unfortunately, regex is still not available as a condition in thunderbird 91.0.2 for filters. after installation there where serval "nul" entries in the menu, after restart they where gone.

I assume you are running FiltaQuilla 3.2 - what language is your Thunderbird version in? These screenshots are from Tb91.0.2 (en-US version)

Configuration from options (you need to activate these): image

Edit Filter Dialog: image

To be extra sure, restart Thunderbird.

mahakala commented 3 years ago

Thanks for your fast reply. I was using the pre86 version from here. Reinstalled thunderbird, took the one from https://addons.thunderbird.net/en-US/thunderbird/addon/filtaquilla/versions/?page=1#version-3.2 and all is fine now 👍

RealRaven2000 commented 3 years ago

Thanks for your fast reply. I was using the pre86 version from here. Reinstalled thunderbird, took the one from https://addons.thunderbird.net/en-US/thunderbird/addon/filtaquilla/versions/?page=1#version-3.2 and all is fine now

Cool. Next time, simply force an update from the Add-ons Manager. 3.2 > 3.2pre86 so it should overwrite any prerelease.

RealRaven2000 commented 3 years ago

Looks like there was a comment "borken again" but it's missing from here - I guess it was deleted?