search

RealRaven2000 / FiltaQuilla

Adds many new mail filter actions to Thunderbird
http://quickfilters.quickfolders.org/filtaquilla.html
GNU General Public License v3.0
88 stars 17 forks source link

Add support for PrintingTools NG Add-on #152

Closed RealRaven2000 closed 2 years ago

RealRaven2000 commented 2 years ago

For the "print" action support a new option to use the print method of @cleidigh in a filter action.

RealRaven2000 commented 2 years ago

PrintingTools will implement a new message listener using runtime.onMessageExternal(..) which must accept a message Id which will be created by the sender of the message (the FiltaQuilla print process).

Resources for conversion: https://webextension-api.thunderbird.net/en/latest/how-to/experiments.html#using-folder-and-message-types

this.extension.messageManager.get(messageId)

extension.messageManger.convert(realMessage)

Sending the message:

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/runtime/sendMessage

RealRaven2000 commented 2 years ago

Pushed changes to ESR78 branch (= current master) changeset:

https://github.com/RealRaven2000/FiltaQuilla/commit/a3730c6e69d61dc1feef951254d6aaf7fa3161e8

I had to add a Notify listener (through John Bieling's NotifyTools API) so I could call sendMessage from the background. Additional permissions needed: messagesRead and notifications

To enable output with PrintingTools NG enable the appropriate option on the "Filter Actions" tab:

image

cleidigh commented 2 years ago

@RealRaven2000 I have the basics in, but I don't know the easiest way to get the xpi

@cleidigh

RealRaven2000 commented 2 years ago

@RealRaven2000 I have the basics in, but I don't know the easiest way to get the xpi

@cleidigh If you don't want to pull ESR78 then just use the version below:

filtaquilla-3.3.1pre21.zip

Install from file should work:

image

cleidigh commented 2 years ago

@RealRaven2000 I am setup and I enabled two actions in fq js and ptng when i create a filter I see the added js action but only the js shows

am i missing configuration? I did reboot after enabling the new actions

RealRaven2000 commented 2 years ago

will have a look tomorrow!

On Wed 16 Feb 2022, 19:35 Christopher Leidigh, @.***> wrote:

@RealRaven2000 https://github.com/RealRaven2000 I am setup and I enabled two actions in fq js and ptng when i create a filter I see the added js action but only the js shows

am i missing configuration? I did reboot after enabling the new actions

— Reply to this email directly, view it on GitHub https://github.com/RealRaven2000/FiltaQuilla/issues/152#issuecomment-1042090440, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQFVMSTTCFGOF7VUZKMAMTU3P4ANANCNFSM5NYTXDGA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

RealRaven2000 commented 2 years ago

@cleidigh can you commit your changes to your 2.0.7 branch?

Or attach your sources / xpi in a comment here... note that comments only accept zip format.

cleidigh commented 2 years ago

hey I am online 2.0.7-b12 has the bk receiver it dumps the msg (no print yet)

i could not get the ptng action fq

time for a call?

RealRaven2000 commented 2 years ago

ok, I mail you an invite now!

cleidigh commented 2 years ago

@RealRaven2000

I just got the notify exp working late so i have to patch in the rest tomorrow @cleidigh

RealRaven2000 commented 2 years ago

@RealRaven2000

I just got the notify exp working late so i have to patch in the rest tomorrow @cleidigh

Oh nice. do you know what it was? I hope my changes were useful to you too.

cleidigh commented 2 years ago

i just did the bare minimum example from JBs readme i still have to get your bk changes in but i think we have all the pieces! C

RealRaven2000 commented 2 years ago

Latest beta version supporting PrintToolsNG: filtaquilla-3.4pre50.zip

I added a mechanism in the options that makes it clear that you need [x] Print enabled in order to activate PrintingToolsNG integration. If [ ] Print is not active the other option will be displayed grayed out (disabled): image

There is also a new debug switch, which can be activated in FQ settings on "About FiltaQuilla / help" by right-clicking the debug checkbox:

image

Activating extensions.filtaquilla.debug.PrintingToolsNG will log a line for each email that is being sent to PrintingToolsNG: printMessage ( 'Filtaquilla - print test' - 29/10/2021 12:01:25 )

To see these messages in error console, you have to enable "Show Content Messages".

Note: PTNG still needs to implement queueing for handling multiple messages / running automatically. It only works reliably when I run a filter manually on a single message.

ASMarvin commented 2 years ago

Hi,

I dont know if this thread is the right one, but I still got some issues with the print filters. The first message that gets printed always comes out 3-5 times. After that the other prints working as intended. Is this a known issue? How can I fix this?

FiltaQuilla-Version: 3.3.1pre15 Thunderbird-Version: 91.6.2

RealRaven2000 commented 2 years ago

I don't know if this thread is the right one, but I still got some issues with the print filters. The first message that gets printed always comes out 3-5 times. After that the other prints working as intended. Is this a known issue? How can I fix this?

FiltaQuilla-Version: 3.3.1pre15 Thunderbird-Version: 91.6.2

Did you try 3.4pre50? It's linked above your question.

ASMarvin commented 2 years ago

Did you try 3.4pre50? It's linked above your question.

not yet. Will give it a try now!

RealRaven2000 commented 2 years ago

Implemented in 3.4, released 18/03/2022