search

RealRaven2000 / QuickFolders

Thunderbird Add-on: QuickFolders
http://quickfolders.org/
Other
48 stars 9 forks source link

Mark as Read (and similar commands) in Navigation bar may address wrong folder #467

Closed RealRaven2000 closed 2 months ago

RealRaven2000 commented 2 months ago

When we use the Navigation (a.k.a Current folder) bar to execute certain functions, it can happen that it applies the command to the wrong folder (if that folder isn't also a QuickFolders tab). I saw this behavior today for the first time, so there must be additional circumstances that give it the wrong document context.

image

I believe this is a regression from Thunderbird 115

It applies to the changed document context used in QuickFolders.Util.getPopupNode( ).

The function is used by and may have affected the following commands:

Mark Folder as Read Mark Newsgroup Read Delete folder (luckily this one asks explicitly with feedback giving the folder name) Empty Trash Empty Junk Delete Junk Folder Properties Open Folder in Explorer Get Messages Repair Folder Create New Subfolder Search Messages

This happened on my production profile today, but I cannot reproduce it on my test profile. IN any case I will make an emergency patch that will use the element.ownerDocument instead of the "global" document variable.

RealRaven2000 commented 2 months ago

Fixed in 6.5.1 - Published 16/04/2024