search

RealRaven2000 / QuickFolders

Thunderbird Add-on: QuickFolders
http://quickfolders.org/
Other
48 stars 9 forks source link

Fix file picker which is broken in Thunderbird 125 #476

Open RealRaven2000 opened 2 weeks ago

RealRaven2000 commented 2 weeks ago

According to bug 1878401 a parameter was changed in mozilla-central for the interface nsIFilePicker.init() - it will fail when we pass in window as first parameter. The c-c source code shows that instead we need to plug in window.browsingContext. This needs to be fixed in a way so that QuickFolders stays compatible with Thunderbird 115 but is also compatible with Thunderbird 125 and later.

RealRaven2000 commented 1 week ago

Here is what happens (tested in Tb 128.0b1) when we try to save the configuration from the license tab:

image

no file picker dialog appears; in error console we see the following exception: 

[Exception... "Could not convert JavaScript argument arg 0 [nsIFilePicker.init]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: jar:file:///I:/Thunderbird_Profiles/ct4akusa.Beta-Test/extensions/quickfolders@curious.be.xpi!/chrome/content/api/Utilities/implementation.js :: fileConfig :: line 35"  data: no]
RealRaven2000 commented 1 week ago

Here is a fixed version:

QuickFolders-mx-6.5.2pre38.zip

This should also be backwards compatible with ESR 115 and all versions in between that and 128.* - no new branch is planned!

To try the version above download zip file and drag the file into Thunderbird Add-ons Manager (do not extract contents, it won't install like that)