Closed RealRaven2000 closed 4 months ago
I have to modify the following string from the change log (and localize to the other 20 languages)
{L1}New option to force lowercase emails when looking up Cardbook contacts. {L2}
Since it won't be an option anymore, it will be something like:
{L1}Force lowercase emails when looking up Cardbook contacts. [issue 278]{L2}
It turns out that he stores all emails in lowercase (according to standard) ....
I'm not sure about this:
cardbook v92.3:
VCARD of this:
Can you please test this new version below? I force lower case conversion on search in this one, it seems to work. Also Phillipe wrote in the Gitlab comment:
new version to test: smartTemplate-fx-4.4pre30.zip
I also removed the option (lcase now forced always before lookup) and updated translations in the new change log:
Implemented in 4.4 - published 28/03/2024
reported over at #257 by @richanl:
After I talked with the author of Cardbook this morning and raised an issue on his Gitlab, It turns out that he stores all emails in lowercase (according to standard) so this means that I can safely convert the email from any AB variable to lowercase when I look up addresses from the Cardbook database. New version will follow below.
I already made a full patch where the switch (conversion to lowercase) was optional and disabled, and I also already made a UI and full translations across all languages in the advanced preferences. I guess I can throw that work away.... it would have just been a one-liner change.