search

RealRaven2000 / quickFilters

Thunderbird Add-on: quickFilters
http://quickfilters.quickfolders.org/
Other
51 stars 11 forks source link

Run filters on folder button doesn't run filters #1

Closed RealRaven2000 closed 4 years ago

RealRaven2000 commented 5 years ago

"I have found that recently in ver 4.1, the run filters on folder Icon/ button has stop working. Menu - Tools, Run filters on folder works."

RealRaven2000 commented 5 years ago

This regression is caused by some code I wrote for Thunderbird 68 - code:

  if (util.versionGreaterOrEqual(util.AppverFull, "67")) {
    var {MailServices} = ChromeUtils.import("resource:///modules/MailServices.jsm"); // new module spelling
  }
  else 
    Components.utils.import("resource:///modules/mailServices.js", {});

the last line will import the Symbol as "mailServices" and not "MailServices"

Fix is to force the new variable name in both cases:

  var {MailServices} = 
    (util.versionGreaterOrEqual(util.AppverFull, "64")) ?
      ChromeUtils.import("resource:///modules/MailServices.jsm") : // new module spelling
      Components.utils.import("resource:///modules/mailServices.js", {});
RealRaven2000 commented 4 years ago

Fixed in version 4.4.1.