RealRaven2000 / quickFilters

Thunderbird Add-on: quickFilters
http://quickfilters.quickfolders.org/
Other
46 stars 11 forks source link

Reply-to cannot be edited #107

Closed RealRaven2000 closed 2 years ago

RealRaven2000 commented 2 years ago

When we use the "reply-to" filter option, it adds the choice "Reply-To" (capitalized first letters) as a search term, however this term cannot be edited anymore, and no visible value is added by the assistant:

image

There should be a text edit field to the right. Adding "reply-to" (all lowercase) as a custom field works, but it is not autofilled by the assistant.

RealRaven2000 commented 2 years ago

According to my tests this works in Thunderbird 68 but not 91 / 101. Guess it is a regression from Thunderbird 91.

RealRaven2000 commented 2 years ago

In error console (both in Tb91 and TB101 when I select the "Reply-To" item) the following error is recorded:

Error: not well-formed XML
    parseXULToFragment chrome://global/content/customElements.js:566
    patchCustomTextbox chrome://quickfilters/content/qFilters-filterEditor.js:387
    callbackCustomSearchCondition chrome://quickfilters/content/qFilters-filterEditor.js:458
    callbackCustomSearchCondition chrome://quickfilters/content/qFilters-filterEditor.js:407
    buildFilter chrome://quickfilters/content/qFilters-worker.js:1465
    createFilter chrome://quickfilters/content/qFilters-worker.js:783
    createFilterAsync_New chrome://quickfilters/content/qFilters-worker.js:1583
XML Parsing Error: not well-formed
Location: moz-nullprincipal:{bb69a86f-c2b7-4148-acc0-e6c9b89123af}
Line Number 6, Column 51:
RealRaven2000 commented 2 years ago

Here is a fixed version:

quickFilters-wx-5.5.2pre4.zip

This works in Thunderbird 91, but there is still a bigger issue in Thunderbird 101.b4 in that the line:

messenger.WindowListener.registerWindow("chrome://messenger/content/FilterEditor.xhtml", 
  "chrome/content/scripts/qFi-filterEditor.js");

is loaded too late, so that the custom search terms cannot be patched.

RealRaven2000 commented 2 years ago

For the issue with Thunderbird 102 I have raised issue #108

RealRaven2000 commented 2 years ago

Latest version:

quickFilters-wx-5.5.2pre19.zip

To install, download zip file and drag into Thunderbird Add-ons Manager (do not unpack contents)

RealRaven2000 commented 2 years ago

Fixed in 5.5.4 - released today