RealRaven2000 / quickFilters

Thunderbird Add-on: quickFilters
http://quickfilters.quickfolders.org/
Other
50 stars 11 forks source link

104.0b3 - not compatible. #124

Closed aprojanos71 closed 2 years ago

RealRaven2000 commented 2 years ago

You probably found that quickFilters is restricted to only working with the ESR version (102.*) - this is done via the manifest entry:

      "strict_max_version" : "102.*"

and is a precaution as I cannot constantly test my Add-ons against beta versions. If you want to have a try you use the build below - if you find any particular stuff that doesn't work with it please append it in a comment. Note that beta versions of Thunderbird may have bugs in them that can propagate into Add-ons, in which case it sometimes makes no sense to write a fix in the Add-on.

quickFilters-wx-5.6pre25.zip

To install, download the zip file and drag it into Thunderbird Add-ons Manager. Do not extract the files.

aprojanos71 commented 2 years ago

Work, but "quickFiltes Assistant" button does not work, and not activ.

RealRaven2000 commented 2 years ago

I installed 104.0b3 and the assistant button goes red at least:

image

No errors in the console at this stage. Also, the assistant is triggered when I drag mail. Can you check your main Error console

(Ctrl_Shift+J).

You can also check the Add-on specific error console for the web-extension parts using tools / developer tools / debug add-ons and then the "Inspect" button on quickFilters:

image

Again, I am not seeing any errors here

aprojanos71 commented 2 years ago

ScreenShot165

RealRaven2000 commented 2 years ago

Can you add more context? Is this happening immediately after startup or when you click something? I cannot read your Thunderbird 's mind ...

More context: 1) enable these 3 Errors / Warnings / Logs 2) you can copy the complete log with right-click (as text) - "Copy all Messages"

image

Also, can you expand the TypError: quickFiters.Util.licenseInfo error so that we may see the stack trace? image

aprojanos71 commented 2 years ago

ScreenShot166

aprojanos71 commented 2 years ago

mail.activity: OnDownloadError: Beérkezett üzenetek of katona1010@gmail.com 2 autosync.jsm:395:16 NS_ERROR_NOT_AVAILABLE: PreferDisplayName: undefined - not a boolean 8 AddrBookCard.jsm:365 mail.activity: OnDownloadError: Beérkezett üzenetek of katona1010@gmail.com autosync.jsm:395:16 TypeError: quickFilters.Util.licenseInfo is undefined quickFilters.js:800:14 onToolbarButtonCommand chrome://quickfilters/content/quickFilters.js:800 onLoad jar:file:///D:/AJ_DATA/AJ_MOZILLA/AJ_MOZILLA/aj71.default-beta/extensions/quickFilters@axelg.com.xpi!/chrome/content/scripts/qFi-messenger.js:66 mail.activity: OnDownloadError: Beérkezett üzenetek of katona1010@gmail.com 2 autosync.jsm:395:16

RealRaven2000 commented 2 years ago

Some Initialisation is missing on your system.

Can you enable debug mode and then switch on notifications: image

extensions.quickfilters.debug.notifications = true

image

PS: If you cannot open the quickFilters settings dialog (because of the error) you can edit the settings in tools / settings / general / {config editor...]

extensions.quickfilters.debug = true
extensions.quickfilters.debug.notifications = true

Don't forget to enable the first 3 options in the error console (errors / warnings / info) or we will miss context!!

image

Then restart Thunderbird and capture the complete log from startup.

Latest version as baseline:

quickFilters-wx-5.6pre28.zip

expected output should look something like this (I tested both with a valid quickFilters license and en empty license):

quickFilters {NOTIFICATIONS} [logTime init]
[object Object]
quickFilters 12:53:10.186  [0 ms]   
Version() getter. addonInfo:
quickFilters 12:53:10.187  [1 ms]   
Adding Custom Term: Reply-To
quickFilters {NOTIFICATIONS} 12:53:10.197  [10 ms]   
onBackgroundUpdates - dispatching custom event quickFilters.BackgroundUpdate.toggleCurrentFolderButtons
into chrome://messenger/content/messenger.xhtml
quickFilters 12:53:10.197  [0 ms]   
toggleCurrentFolderButtons()
quickFilters {NOTIFICATIONS} 12:53:10.198  [1 ms]   
onBackgroundUpdates - dispatching custom event quickFilters.BackgroundUpdate.updatequickFiltersLabel
into chrome://messenger/content/messenger.xhtml
quickFilters 12:53:11.202  [1004 ms]   
=================quickFilters==============
   checkFirstRun() - attempt 1
quickFilters 12:53:11.202  [0 ms]   
Version() getter. addonInfo:
quickFilters 12:53:11.202  [0 ms]   
firstRun = false  - currentVersion = 5.6pre28  - installed = 5.6
quickFilters 12:53:11.202  [0 ms]   
store installedVersion: 5.6
aprojanos71 commented 2 years ago

ScreenShot168

aprojanos71 commented 2 years ago

ScreenShot169

aprojanos71 commented 2 years ago

ScreenShot170

RealRaven2000 commented 2 years ago

the btnApply is null can be fixed. I still don't know why the licensInfo is not initialized by the notification listener you should see some messages starting with quickFilters {NOTIFICATIONS} - are you sure that logging "info" is enabled?

quickFilters-wx-5.6pre29.zip

Made a fix for the btnApply message - (I had made some changes in the meantime because of #122 - which affect you because you don't have all buttons on the toolbar: image

aprojanos71 commented 2 years ago

installed 29.zip and the quickFilter toolbar has disappeared.

aprojanos71 commented 2 years ago

ScreenShot171

aprojanos71 commented 2 years ago

15:33:52.308 unexpected token: identifier qFi-messenger.js:72:16 _loadIntoWindow jar:file:///D:/AJ_DATA/AJ_MOZILLA/AJ_MOZILLA/aj71.default-beta/extensions/quickFilters@axelg.com.xpi!/chrome/content/api/WindowListener/implementation.js:968 onLoadWindow jar:file:///D:/AJ_DATA/AJ_MOZILLA/AJ_MOZILLA/aj71.default-beta/extensions/quickFilters@axelg.com.xpi!/chrome/content/api/WindowListener/implementation.js:687 checkAndRunExtensionCode resource:///modules/ExtensionSupport.jsm:218 _checkAndRunMatchingExtensions resource:///modules/ExtensionSupport.jsm:190 registerWindowListener resource:///modules/ExtensionSupport.jsm:69 forEach self-hosted:3866 registerWindowListener resource:///modules/ExtensionSupport.jsm:68 startListening jar:file:///D:/AJ_DATA/AJ_MOZILLA/AJ_MOZILLA/aj71.default-beta/extensions/quickFilters@axelg.com.xpi!/chrome/content/api/WindowListener/implementation.js:569 startListening self-hosted:1151 result resource://gre/modules/ExtensionParent.jsm:1125 withCallContextData resource://gre/modules/ExtensionParent.jsm:608 result resource://gre/modules/ExtensionParent.jsm:1124 withPendingBrowser resource://gre/modules/ExtensionParent.jsm:618 result resource://gre/modules/ExtensionParent.jsm:1123 callAndLog resource://gre/modules/ExtensionParent.jsm:1076 recvAPICall resource://gre/modules/ExtensionParent.jsm:1122 AsyncFunctionNext self-hosted:668

RealRaven2000 commented 2 years ago

Sorry my fault- I had to rush out, and my office roof was being redone. typo! I typed ig insted of if. Fixed version:

quickFilters-wx-5.6pre30.zip

once it is installed check what happens if you drag all 4 buttons into the toolbar. (You may have to restart the Add-on or Thunderbird afterwards, I don't think the click event handlers are added just by dragging to the toolbar - they are added when quickFilters starts)

aprojanos71 commented 2 years ago

Works fine! Thx! :-)

RealRaven2000 commented 2 years ago

Any news on this?