RealRaven2000 / quickFilters

Thunderbird Add-on: quickFilters
http://quickfilters.quickfolders.org/
Other
50 stars 11 forks source link

Assistant triggered when emails are deleted (quickFilters 5.7) #142

Closed RealRaven2000 closed 1 year ago

RealRaven2000 commented 1 year ago

When the assistant is active, deleting emails triggers it and prompts to create new filters. This behavior is unintended.

RealRaven2000 commented 1 year ago

Quick Fix version below:

quickFilters-wx-5.7.1pre2.zip

This solution suppresses the Assistant if mail is moved to the following special folders: Trash Junk Queue Templates Sent Mail Drafts Newsgroup

We might need more?

To install, download the zip file, then drag the file into Thunderbird Add-ons Manager (do not extract contents).

RealRaven2000 commented 1 year ago

A user also didn't want archiving message to trigger the assistant. If we change this behavior, and suppress archiving as trigger, then it will not be possible to use the Assistant to create new filters that archive mail. But I am not sure whether this is a valid use case right now. Will investigate....

PotatoCarl commented 1 year ago

Hi This version works wenn deleting messages (no filter popup). Still shows the filter popup when archiving messages. When archiving i definetly want them to go to Archiv if not i use a filter. Behavior for popping up filter proposals should be switchable to exclude standard actions (delete, archiv ) Just like in previous versions basically. Thanks apreaciate the quick support.

RealRaven2000 commented 1 year ago

New version suppressing Archived messages. I am not sure if archiving is done by year and whether all subfolders under archives may receive the flag correctly.

quickFilters-wx-5.7.1pre5.zip

To install, download the zip file, then drag the file into Thunderbird Add-ons Manager (do not extract contents).

Note that this behavior may still be different from the previous versions of quickFilters as they had different reactions depending on what user actions were taken. I am also working on a fix for multiple assistant windows being caused by dropping multiple mails to a QuickFolders tab (or folder submenu / quickMove result thereof) and will upload a fix shortly there at:

https://github.com/RealRaven2000/QuickFolders/issues/335

RealRaven2000 commented 1 year ago

I moved this issue to the quickFilters repository (I had accidentally added it to my Add-on FiltaQuilla) - sorry about the noise.

hartholzpirat commented 1 year ago

Thank you everything worked

RealRaven2000 commented 1 year ago

Thank you everything worked

I have another HUGE problem. When filters are triggered automatically (or when I run them via the run filters on selected messages) this also invokes the assistant on my production profile. This is extremely problematic, as I cannot tell in the folder listener that checks for moved / copied messages what invoked the function. I need to open another bug for this one, if it doesn't work out I may have to roll back all the changes from the change set to "Remove monkey patch code for Tb move mail commands". This is going to get ugly... will raise a separate issue for it

RealRaven2000 commented 1 year ago

Fixed in 5.7.1 - Published 26/Dec/2022

RealRaven2000 commented 1 year ago

Please refer to #145 for changes relating to delete / archiving