RealRaven2000 / quickFilters

Thunderbird Add-on: quickFilters
http://quickfilters.quickfolders.org/
Other
46 stars 11 forks source link

Sort filter fails in Betterbird #151

Open RealRaven2000 opened 1 year ago

RealRaven2000 commented 1 year ago

Sorting filters doesn't work in the latest version of Betterbird.

Error log:

searchTerm: termIdxFromRichlistIdx 0 -> -1 searchTerm.js:58:15
searchTerm: termIdxFromRichlistIdx 1 -> 0 2 searchTerm.js:70:13
searchTerm: termIdxFromRichlistIdx 2 -> 1 searchTerm.js:70:13
initializeSearchRows: set top-most to or from 1 searchTerm.js:337:17
searchTerm: termIdxFromRichlistIdx 2 -> 1 searchTerm.js:70:13
searchTerm: termIdxFromRichlistIdx 3 -> 2 searchTerm.js:70:13
initializeSearchRows: set top-most to or from 2 searchTerm.js:337:17
searchTerm: termIdxFromRichlistIdx 3 -> 2 searchTerm.js:70:13
searchTerm: termIdxFromRichlistIdx 4 -> 3 searchTerm.js:70:13
initializeSearchRows: set top-most to or from 3 searchTerm.js:337:17
searchTerm: termIdxFromRichlistIdx 4 -> 3 searchTerm.js:70:13
searchTerm: termIdxFromRichlistIdx 5 -> 4 searchTerm.js:70:13
initializeSearchRows: set top-most to or from 4 searchTerm.js:337:17
searchTerm: initializeSearchRows - exit 0: and   level 1 searchTerm.js:44:13
searchTerm: initializeSearchRows - exit 1: or   level 1 searchTerm.js:44:13
searchTerm: initializeSearchRows - exit 2: or   level 1 searchTerm.js:44:13
searchTerm: initializeSearchRows - exit 3: or   level 1 searchTerm.js:44:13
searchTerm: initializeSearchRows - exit 4: or   level 1 searchTerm.js:44:13
TypeError: gFilter.searchTerms[i] is undefined qFilters-filterEditor.js:142:15
ReferenceError: gTotalSearchTerms is not defined qFilters-filterEditor.js:391:14
RealRaven2000 commented 1 year ago

This may be due to a missing (or differently named) variable [gTotalSearchTerms]. In the Thunderbird codebase this is defined here:

https://searchfox.org/comm-central/rev/5fb08affe686ce86e49678f02d82fcce06370525/mailnews/search/content/searchTerm.js#7

Lab-doc commented 1 year ago

It seems there is a bigger issue: Clicking Sort deletes the items in the filter search list. This occurs in the previous Betterbird release and current release (just posted): 102.7.0-bb28 (64-bit)