RealRaven2000 / quickFilters

Thunderbird Add-on: quickFilters
http://quickfilters.quickfolders.org/
Other
46 stars 11 forks source link

Does legacy version still got attension? Version 3.12.2 crashes thunderbird 52ESR #159

Open luweitest opened 1 year ago

luweitest commented 1 year ago

I am on a laptop which cannot upgrade from windows xp due to hardware limits. So I have to use thunderbird 52.9. The steps to crash: I made a clean profile, installed quickfilters 3.12.3 only, added a newsgroup account, created two filter rules, selected them, clicked the "sorting" buttom, and TB crashed. The generated crash file in the profile directory is attached. I also tried version 3.12.2 and 2.7.1, both crashed. Hope you could have time to look into this. crashes.zip

RealRaven2000 commented 1 year ago

This is difficult, I am currently testing with 102 and 110beta4, I can also test with 91. I cannot release new versions for any versions of Thunderbird before 78 because they use a different install manifest (chrome.manifest). On top of that it is really difficult to have test profiles for lots of different outdated versions of Thunderbird. I did release some legacy versions here on github see here a version from April 2021:

https://github.com/RealRaven2000/quickFilters/releases/tag/4.5

this one is compatible with the old version of Thunderbird (68) before the big change to "mail extensions" in Thunderbird 78. But minimum version of that is Thunderbird 60. (now 42 major version numbers behind the current ESR version, 102.7.2). It would be easier to fix if it wasn't just crashing outright but just to have a log from the error console, because I can't really install so many outdated versions on my development machine and maintain test profiles for all of them. I know it's difficult to upgrade I was running Windows XP (which is not not supported for 12 years by Microsoft) until last year, but at some stage you got to cut your losses. Maybe don't use the sort feature on that machine?

I am not able to read your crash log, a console output would be much more useful. Do enable debug mode in quickFIlters settings / Advanced on the bottom right (sorry I don't have old screenshots):

image

You can open error console with Ctrl+Shift+J and capture the errors there by right-clicking or at least highlighting and copying all messages. I can do a little change log archeology to see if any sorting bugs were fixed in later versions.

RealRaven2000 commented 1 year ago

There are some additional ways of logging you may try:

https://wiki.mozilla.org/MailNews:Logging#Thunderbird_Logging

just guarantee they are all in that old version. Might not be worth the hassle?

luweitest commented 1 year ago

Thank you for the reply. As I ticked the "Debug mode", I managed to have these log in error console after I selected two filters, before clicking the sort button: ` Keyframe rule ignored due to bad selector. license.css:19:52 XUL box for hbox element contained an inline #text child, forcing all its children to be wrapped in a block. quickFilters-options.xul TypeError: this._buttons is undefined[Learn More] dialog.xml:81:11 GET XHR https://aus5.mozilla.org/update/6/Thunderbird/52.9.1/20180709124824/WINNT_x86-msvc-x86/en-US/release/Windows_NT%205.1.3.0%20(x86)/SSE2/default/default/update.xml [HTTP/2.0 200 OK 140ms] POST http://ocsp.digicert.com/ [HTTP/1.1 200 OK 1062ms] quickFilters [logTime init] quickFilters.editorDomLoaded() quickFilters 17:29:41.34 [144 ms]
quickFilters.loadEditor() quickFilters 17:29:41.144 [110 ms]
No arguments for highlighting duplicates. quickFilters 17:29:41.144 [0 ms]
quickFilters.FilterEditor.showTitle() - filterName = quickFilters 17:29:41.848 [704 ms]
quickFilters.addTagListener: ToggleMessageTag.fromQuickFilters already is set

quickFilters 17:29:55.886 [14038 ms]
quickFilters.Util.accept([object ChromeWindow]) quickFilters [logTime init] refreshDuplicates(true) ... quickFilters 17:29:55.886 [0 ms]
Duplicates dropdown: [object XULElement] quickFilters [logTime init] quickFilters.editorDomLoaded() quickFilters 17:30:3.936 [118 ms]
quickFilters.loadEditor() quickFilters 17:30:4.38 [102 ms]
No arguments for highlighting duplicates. quickFilters 17:30:4.38 [0 ms]
quickFilters.FilterEditor.showTitle() - filterName = quickFilters 17:30:4.782 [744 ms]
quickFilters.addTagListener: ToggleMessageTag.fromQuickFilters already is set

quickFilters 17:30:13.230 [8448 ms]
quickFilters.Util.accept([object ChromeWindow]) quickFilters 17:30:13.230 [17344 ms]
refreshDuplicates(true) ... quickFilters 17:30:13.230 [0 ms]
Duplicates dropdown: [object XULElement] `

luweitest commented 1 year ago

I tried "Thunderbird Logging" as suggested. I created log.bat:

set_ NSPR_LOG_MODULES=Filters:5 set NSPR_LOG_FILE=.\Filters.log "C:\Program Files\Mozilla Thunderbird\thunderbird.exe"

Then repeated the steps, but Filters.log has 0 bytes. As console log is not available when crashing, it seems the crash log is the only thing that could get. If you have further guide, I'd willing to test. Anyway, I can still use features like "merge" and "move". Thanks!

RealRaven2000 commented 1 year ago

the filters log is only populated while filtering. what we need is JavaScript warnings and errors - not sure if your version of Thunderbird supports it. I was told the command line mode o referred to was only available on Mac.

On Thu 16 Feb 2023, 10:01 luweitest, @.***> wrote:

I tried "Thunderbird Logging" as suggested. I created log.bat: set NSPR_LOG_MODULES=Filters:5 set NSPR_LOG_FILE=.\Filters.log "C:\Program Files\Mozilla Thunderbird\thunderbird.exe" Then repeated the steps, but Filters.log has 0 bytes.

— Reply to this email directly, view it on GitHub https://github.com/RealRaven2000/quickFilters/issues/159#issuecomment-1432824690, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQFVMUR56OIFQEC6WJKCBDWXX3H5ANCNFSM6AAAAAAU53RJRI . You are receiving this because you commented.Message ID: @.***>

luweitest commented 1 year ago

JavaScript warnings and errors are in error console, which could only get before crashing. After crashing the mozilla crash reporter could gather some info. I provide another log as the attachment. test.zip