RealRaven2000 / quickFilters

Thunderbird Add-on: quickFilters
http://quickfilters.quickfolders.org/
Other
46 stars 11 forks source link

Autostart assistant problems: button not highlighted when updating / starting Add-on from extension manager #210

Open RealRaven2000 opened 10 months ago

RealRaven2000 commented 10 months ago

When we update quickFilters using the Add-ons Manager tab (e.g. through manual update or installing the extension manually, or if we activate it from there, the automatic startup doesn't fully work: the toolbar buttons will not show as red / active when switching to any folder / mail tab.

Also, after an update, when clicking the "news" panel, the button does not show as "assistant active" when it is restored to its normal looks.

RealRaven2000 commented 10 months ago

These are all regressions following the radical rewrite that the Thunderbird 3pane and toolbar handling has underwent in Thunderbird 115.

At the moment the routine that listens for toolbar button changes is only in the main window overlay script;

RealRaven2000 commented 10 months ago

I found out that the function updatequickFiltersLabel() needs to badly become aware of assistant status; this way if there are any changes to the button label that follow from reading release notes, updating the license status etc. will always make sure the assistant status (red icon color, if it is active) remains visible no matter how the looks of the toolbar button are modified otherwise. I also added a new test menu item under tools to trigger the news flag which causes the button to show the "quickFilters was updated" message.

image

Here is a version that addresses most of the described issues:

quickFilters-wx-6.2.2pre10.zip

It (likely) still needs a bunch of testing for hardening...


(as usual) to test the version above, download the zip file, drag into Thunderbird Add-ons Manager, do not extract contents or if won't install.