search

RealRaven2000 / quickFilters

Thunderbird Add-on: quickFilters
http://quickfilters.quickfolders.org/
Other
46 stars 11 forks source link

QuickFilters toolbar button shines (is always active) #223

Open ThiloteE opened 8 months ago

ThiloteE commented 8 months ago

System: Windows 10, Betterbird 115.4

How it looks like: image

How it is supposed to look like: image

How to reproduce:

  1. Start Betterbird.
  2. See that the QuickFilter toolbar button does NOT shine. (good)
  3. Click the QuickFilter toolbar button.
  4. Click somewhere else in the Betterbird UI.
  5. See that the QuickFilter toolbar button does continue to shine. (bad)
  6. Restart Betterbird
  7. See that the QuickFilter toolbar button does not shine. (good).
RealRaven2000 commented 8 months ago

When you say "shine", you probably mean an outline in dark mode, like this:

image

I am doing some none-standard styling and am currently not using the pure API to build the menu, instead inject it using the experimental WindowListener API.

one of my main reasons for this is the handling of updates, because I do not like popup windows that are just shown to the user arbitrarily. instead I like to restyle the button and ask the user to click it when they have time for it.

It seems like the styling is caused by the attribute aria-pressed="true" - which is something that should be removed automatically when another screen element is pushed or the popup menu is closed. Maybe I need to monitor this manually somehow and add event listeners for it losing focus to fix it.

ThiloteE commented 8 months ago

Hey Axel, yes you go tthat right. I mean the outline in darkmode. Thank you for your consideration.