search

RealRaven2000 / quickFilters

Thunderbird Add-on: quickFilters
http://quickfilters.quickfolders.org/
Other
46 stars 11 forks source link

Feature request: Tags Popup integration to trigger quickFilters assistant #224

Open 121sim opened 7 months ago

121sim commented 7 months ago

Hi,

I was wondering what triggers the option : "Run filters automatically when tags are change" as it does work with a right click on the message / assign a tag /, but it doesn't seem to work when using the "Tag Popup" addon (by [H.Ogi] user) by clicking on the header message (see picture below).

image

I guess it's related to the Tag Popup addon and I will ask the author too, tho it seems to use the same tags system as Quickfilters (all labels are available at the same place, and when using the right click method any label works).

Thanks.

RealRaven2000 commented 7 months ago

So the problem is - I cannot use a simple tag listener (a routine that checks whether a tag was changed) to trigger the assistant, because filters can change tags too. And we do not want a filter to cause the assistant to create a new filter. It's same as with moving emails: I tried to change the detection of the event of moving them to a folder listener but it was a desaster, because there is no easy way to discern whether a user has moved the email or whether it was done by a filter action.

So any user interaction that can trigger the assistant by changing a tag or the location of an email must be handcrafted to the specific method. Personally, I am using tag popup too but via the unified toolbar button, mainly to manage licensing emails:

image

There is no easy way to do this via the standard API, instead there would be 2 possible paths 1 - monkey patch the existing functions from the other Add-on - this is the quick and dirty way but may potentially be unstable, because to monkey patch a function it has to exist as an experiment and has to be loaded before the quickFilters Add-on is loaded. The load order of Add-ons is never guaranteed 2 - we could try and collaborate with the author of the Add-on and make a notification method in quickFilters that could be called or registered on his side. I have done collaborations like this before with the Add-ons PrintingTools NG and Cardbook, both authors of which regularly join the weekly Add-on developer Zoom meeting.

121sim commented 7 months ago

Thanks for your detailed reply.

RealRaven2000 commented 7 months ago

Thanks for your detailed reply.

If you open up an issue with the author of Tag popup, can you link it here please? (assuming he also has a public tracking system).

121sim commented 7 months ago

Sure : https://hogi.sakura.ne.jp/hiki/?Ticket-438