quickfilters does not trigger assistant in Betterbird when Deleting mail

RealRaven2000 / quickFilters

Thunderbird Add-on: quickFilters

http://quickfilters.quickfolders.org/

Other

46 stars 11 forks source link

quickfilters does not trigger assistant in Betterbird when Deleting mail #225

Closed GoeWink closed 2 months ago

GoeWink commented 7 months ago

Since the last upsatge of Betterbird (115.4.2-bb17 (64-Bit)) Quickfilter do not any longer after start the assistent

recognizew new tag
- recognize DELETE as the function to move into trash. So it does not open the dialogue for new filter
- if there is more than 1 tag the filtering do not work (maybe 1 tag to mark, 1 tag for filtering)
- So without creating a new filter the assistant stay "ON" (I have marked to close after each creating filter...
On Windows10, Quzickfilters actual.
I found a ZIP file in the other tread for Betterbird. But this seems to be to old because this removed the Quickfilters buton ans I had to delete and reinstall the add on..

RealRaven2000 commented 7 months ago

I was using a monkeypatch that overwrites DefaultController, which used to be in charge of loads of commands such as cmd_delete but I see that doesn't appear to be called in this case. Have to find out when it is instantiated and whether there is now a separate one for each tab, and then monkeypatch that / those one by one and also have a method of restoring them when quickFilters is removed / updated / disabled etc.

the difficulty is often to find when and where from the code for global overrides like this can be called.

RealRaven2000 commented 2 months ago

try the file below. make sure deleting is not exluded in the setting Actions / Assistant should ignore...

quickFilters-wx-6.4pre50.zip

To install version above download zip file and drag the file into Thunderbird Add-ons Manager (do not extract contents, it won't install like that)

RealRaven2000 commented 2 months ago

Fixed in 6.4 - Published 11/04/2024