RealRaven2000 / quickFilters

Thunderbird Add-on: quickFilters
http://quickfilters.quickfolders.org/
Other
46 stars 11 forks source link

Dialog buttons cut off on filter assistant window (Ubuntu 22.04) #243

Open R7914T opened 1 month ago

R7914T commented 1 month ago

I wanted to make a filter to move items from the inbox to a specified folder. I went to the folder, found an appropriate email and tried to create the filter. Just bellow the bottom of the screen are two buttons that are mainly off screen. I do not know which button to click to confirm the filter. I tried to follow a similar query raised here but could not work out the exact instructions for Ubuntu 2204.

RealRaven2000 commented 1 month ago

Can you add a screenshot please? I did some minor layout fixes in 6.4

This is what the dialog looks like in Windows: image

The window can be resized, but something in the layout makes it have a minimal height - if there is a problem eith vertical space here i could add a button above the header preview area to collapse / show it?

RealRaven2000 commented 1 month ago

Here is a suggestion on how I could improve the dialog:

image

RealRaven2000 commented 1 month ago

Here is a test version, can you try it out? It's still a little clunky, when I decrease the top description it seems to increase horizontal width of the dialog, not quite sure how to solve this yet, as these are some idiosyncratic flex properties of the old xul items. I will probably need to rewrite the dialog as HTML5 soon anyway and take full control of all layout rules.

quickFilters-wx-6.5pre12.zip

I am calling the system function window.sizeToContent() when you collapse / expand one of these sections, they theroretically should include the dialog buttons at the bottom after this.


To try the version above download zip file and drag the file into Thunderbird Add-ons Manager (do not extract contents, it won't install like that)

RealRaven2000 commented 1 month ago

Here is another iteration. I heard from a Thunderbird employee today that indeed the legacy dialog is broken so I as a next step will have to convert to an ordinary window and implement the dialog buttons (on the bottom) myself as part of the page; this should also fix flow problems like this.

Also according to Mozilla the function window.sizeToContent() will be deprecated in future versions so we need to make sure the content is fully responsive and adapts to the window size. This means I will probably make the dialog buttons static and pin them to the bottom, and add vertical scroll bars to the window content if vertical space runs out.

quickFilters-wx-6.5pre15.zip

I decided to not use the XUL <description> tag and used an ordinary <p> for the filter description instead:

image


To try the version above download zip file and drag the file into Thunderbird Add-ons Manager (do not extract contents, it won't install like that)