RealRaven2000 / quickFilters

Thunderbird Add-on: quickFilters
http://quickfilters.quickfolders.org/
Other
46 stars 11 forks source link

Backup does not work ... clicking on the button does nothing .. popup dialog does not open (Betterbird 115; Ubuntu) #245

Open wwender opened 1 week ago

wwender commented 1 week ago

Thunderbird: Betterbird 115.12.0-bb29 (64-bit) OS: Ubuntu 22

Debug Log Messages (XXX for hiding personal information) :


quickFilters [logTime init]
 Adding FilterList... [qFilters-utils.js:720:13](chrome://quickfilters/content/qFilters-utils.js)
Manually calling notifyTools.enable() is no longer needed. [notifyTools.js:145:13](jar:file:///home/XXXXX/.thunderbird/XXXXX.XXXXX/extensions/quickFilters@axelg.com.xpi!/chrome/content/scripts/notifyTools.js)
quickFilters  quickFilters.Init()  
        Assistant active: false
        BrowserInfo: [object Object]

There is a list of messages like : # 1. Added filter to JSON: XXXX


quickFilters 11:6:43.457  [0 ms]   
 24. Added filter to JSON: XXXXX
quickFilters 11:6:43.458  [1 ms]   
 popupAlert(Archiving 24 Filters, quickFilters) [qFilters-utils.js:720:13](chrome://quickfilters/content/qFilters-utils.js)
Uncaught (in promise) NS_ERROR_FILE_UNRECOGNIZED_PATH: Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIFile.initWithPath]
    fileFilters chrome://quickfilters/content/qFilters-list.js:1710
    store chrome://quickfilters/content/qFilters-list.js:1902
    onclick chrome://messenger/content/FilterListDialog.xhtml:1

   No popup is shown ... just a silent dead ...            

wwender commented 1 week ago

I think I solved it :

let dPath = prefs.getStringPref('files.path');
        if (dPath) {
            let defaultPath = Cc["@mozilla.org/file/local;1"].createInstance(NSIFILE);
            defaultPath.initWithPath(dPath);

There is a config setting "extensions.quickfilters.files.path" this seems to have a value from a former windows system (the profile had also been used on a windows system) ... after I set extensions.quickfilters.files.path it worked .

RealRaven2000 commented 1 week ago

thanks for reporting this, I can make this more robust for the future.

wwender commented 1 week ago

👍

RealRaven2000 commented 1 week ago

I will look at a workaround anyway it should not fail silently even if the path is garbage. Will close the issue myself once it is implemented and a new version released that contains the fix..