RealRaven2000 / quickFilters

Thunderbird Add-on: quickFilters
http://quickfilters.quickfolders.org/
Other
49 stars 11 forks source link

Make quickFilters compatible with Thunderbird 91 #48

Closed RealRaven2000 closed 2 years ago

RealRaven2000 commented 3 years ago

Thunderbird 86 introduced multi-process browsing (e10s a.k.a. electrolysis) which creates some compatibility issues with some functions.

Quick patch version for 86.0b3: quickFilters-wx-5.2pre6.zip

To install, download the xip file and drag into Thunderbird Add-ons Manager.

Ongoing bugfixes for beta versions will go here.

RealRaven2000 commented 3 years ago

Importing filters and filter trouble shooter wasn't working. Also any filters that have no search condition at all will disrupt the troubleshooting process.

Patched version: quickFilters-wx-5.2pre20.zip

aprojanos71 commented 3 years ago

Super! It works! I see the names of the faulty filters and the backup also works fine. Thx!

aprojanos71 commented 3 years ago

Merge does not work ...

RealRaven2000 commented 3 years ago

Merge does not work ...

thanks for finally using github for bug reporting. What exactly doesn't work - how do you invoke it?

When you merge filters they have to have the same (main) action - e.g. move mails to the same folder. You can select 2 filters with the same action and do merge manually or you are prompted to merge when you add new condition to an existing filter - e,g, dropping an email to a folder that already has filters addressing it.

RealRaven2000 commented 3 years ago

I tested in Tb86.0b3 with the assistant (assistant is active, I already had a filter that moves mail to pinterest) I moved a mail to the folder "pinterest" and it came up with the merge suggestion for the existing filter. I was able to successfully merge in the condition "recommendations@explore.pinterest.com" which was not pre-existing in the filter. (the condition with @pinterest already existed)

image

image

aprojanos71 commented 3 years ago

When I select two filters and want to merge, it does nothing. The two filters do the same thing - [move to spam] - but do nothing.

Uncaught TypeError: stCollection.Count is not a function qFilters-utils.js:1236:63 copyTerms chrome://quickfilters/content/qFilters-utils.js:1236 merge chrome://quickfilters/content/qFilters-list.js:423 oncommand chrome://messenger/content/FilterListDialog.xhtml:1 [Learn More] copyTerms chrome://quickfilters/content/qFilters-utils.js:1236 merge chrome://quickfilters/content/qFilters-list.js:423 oncommand chrome://messenger/content/FilterListDialog.xhtml:1

aprojanos71 commented 3 years ago

ScreenShot098

RealRaven2000 commented 3 years ago

Try this version:

quickFilters-wx-5.2pre24.zip

There was another instance of searchTerms.Count() which is not supported in Thunderbird 86, I think they changed the type of the searchTerms attribute from nsIMutableArray to an Array<nsIMsgSearchTerm>. See code: comm-esr78 comm-central

Still a side effect from not using APIs I think changes like these will be even more frequent this year:

https://bugzilla.mozilla.org/show_bug.cgi?id=857230

aprojanos71 commented 3 years ago

Yes, it works! Thx!

RealRaven2000 commented 3 years ago

Here is the latest version which can run on Thunderbird 88.0b1 - note that the new "sort search terms" feature in the filter editor is still experimental!

quickFilters-wx-5.2pre59.zip

Install by downloading the zip file and then dropping it into Thunderbird Add-ons Manager. Compatible from Thunderbird 78 forward. I had to drop the strict_max_version for now, because 88.0 isn't yet listed as valid version but absolutely no guarantees for running it in 89 or higher!!

RealRaven2000 commented 3 years ago

Latest version, including the "Sort search terms" feature on the edit filter dialog:

quickFilters-wx-5.2pre72.zip

Install by downloading the zip file and then dropping it into Thunderbird Add-ons Manager. Compatible from Thunderbird 78 forward.

RealRaven2000 commented 3 years ago

Problem on the support tab in Thunderbird 91.0b1 with descriptions for the buttons "sliding down" to the bottom: image

Also, when trying to open the debug settings via right-click, the about:config panel is not opened anymore: image

RealRaven2000 commented 3 years ago

Latest version see below Changes:

quickFilters-wx-5.3pre136.zip

To install, download the zip file and then drag that file into Thunderbird Add-ons Manager.

RealRaven2000 commented 3 years ago

Latest version see below Changes:

quickFilters-wx-5.3pre154.zip

To install, download the zip file and then drag that file into Thunderbird Add-ons Manager.

RealRaven2000 commented 3 years ago

Latest Version Changes:

quickFilters-wx-5.3pre167.zip

To install, download the zip file and then drag that file into Thunderbird Add-ons Manager.

RealRaven2000 commented 3 years ago

I uploaded a new release to ATN this morning, see https://github.com/RealRaven2000/quickFilters/releases/tag/5.3.1 In this one, I do not set strict_max_version (mainly because there are no "legal" values greater than 91.0a1 available to the current validator) - I only have tested it as far as the current 92 daily. But it should be fully compatible with 91.0 ESR as far as I can tell. Leaving this issue open for Tb91 related regressions until the majority of users are migrated to it.

I also finally created the product for a quickFilters domain license on the fastspring shop. I just need to add the decryption keys for domain licenses in the next quickFilters release

RealRaven2000 commented 2 years ago

Closing this bug now as we move on into the phase of using more official API technology and slowly replacing experimental APIs where possible