search

RealRaven2000 / quickFilters

Thunderbird Add-on: quickFilters
http://quickfilters.quickfolders.org/
Other
49 stars 11 forks source link

Make quickFilters compatible with TB87 beta #49

Closed aprojanos71 closed 3 years ago

aprojanos71 commented 3 years ago

Not working.

RealRaven2000 commented 3 years ago

Mainly a version bump for strict_max_version, but I had to also fix opening URLs (the contentPage parameter is now ignored) Also note that options are now in the "..." Menu:

image

quickFilters-wx-5.2pre25.zip

If you find any regressions in TB87 betas, please add them below...

aprojanos71 commented 3 years ago

Super! :) Thx!

RealRaven2000 commented 3 years ago

The array of search terms has changed from nsIMutableArray to Array https://searchfox.org/comm-central/source/mailnews/search/public/nsIMsgFilter.idl#79

this will require rewriting all functions that iterate through search terms, e.g. when copying / pasting / merging filters. At the moment, I have wrapper code that is based on the nsIMutableArray format that will fail in Tb87++

RealRaven2000 commented 3 years ago

The array of search terms has changed from nsIMutableArray to Array https://searchfox.org/comm-central/source/mailnews/search/public/nsIMsgFilter.idl#79

this will require rewriting all functions that iterate through search terms, e.g. when copying / pasting / merging filters. At the moment, I have wrapper code that is based on the nsIMutableArray format that will fail in Tb87++

Hmm, seems like I already took care of it, as long as I use my wrapper functions from quickFilters-util.js:

util.querySearchTermsArray(searchTerms)
util.querySearchTermsAt(searchTerms, i)
util.querySearchTermsLength(searchTerms)
RealRaven2000 commented 3 years ago

I am closing this as duplicate of #48 - which I bounced to Tb 88