search

RealToken-Community / dashboard-v2

https://dashboard.realtoken.community
5 stars 4 forks source link

Add euro fiat currency support #12

Closed anthony-robin closed 1 year ago

anthony-robin commented 1 year ago

Fiat prices are currently displayed in dollars and no option exists yet to convert it to euros.

It would be a good enhancement to allow a new option to switch on the fly to another fiat currency:

Capture d’écran 2023-09-10 à 18 36 33

Does the RealT API has an existing endpoint that return multiple fiat currencies or do we have to rely on another external webservice to convert it ?

Thank you :)

NandyBa commented 1 year ago

I propose to use EUR / USD Chainlink price feed. We can relay on Gnosis Chainlink price feed or use Ethereum one both are marked as verified feeds

NandyBa commented 1 year ago

Note: Waiting #7 pull request introduce Chainlink price feed so implementation can be quick

anthony-robin commented 1 year ago

Awesome ! Thank for explaining it and linking the doc, I will wait for your PR to be merged first :)

NandyBa commented 1 year ago

You welcomed ! @anthony-robin maybe you can review #7 (check the change made on works correctly on your side) so we can merge it and start your's.

NandyBa commented 1 year ago

PR #7 merged. @anthony-robin do you want to implement this issue by yourself or you don't care ?

anthony-robin commented 1 year ago

Yes, I will work on it !