RealismusModding / FS17_seasons

Farming Simulator 17 seasons mod
https://www.realismusmodding.com/mods/seasons
75 stars 55 forks source link

[WF] Create an overlay to display weather forecast and season #12

Closed theSeb1979 closed 7 years ago

theSeb1979 commented 7 years ago

This should be an overlay which is displayed on the screen. Possibly above the vehicle hud, or below the time hud. If it's below the time hud, then it will conflict with the Livestock manager mod.

But, looking at livestock manager, it adds itself into g_currentMission, so we can check for its presence and move the hud down, if necessary.

ian898 commented 7 years ago

I am trying to createOverlay from the existing icon set ingame but its not as easy as I thought lol

ian898 commented 7 years ago

Well that why I cant reference them they have uv maped the icons all together haha. screenshot 2016-11-09 12 09 00

ian898 commented 7 years ago

I have it now :D,

What are we thinking bigger?

fsscreen_2016_11_09_15_01_37

joskuijpers commented 7 years ago

I think it is big enough

On 09 Nov 2016, at 16:03, ian898 notifications@github.com wrote:

I have it now :D,

What are we thinking bigger?

https://cloud.githubusercontent.com/assets/3869352/20142634/85340ab6-a68d-11e6-894e-e56ea4672aee.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/theSeb1979/FS17_seasons/issues/12#issuecomment-259435043, or mute the thread https://github.com/notifications/unsubscribe-auth/AEyN0HVt_UJN23IyCqSuZ8Q26Ib90_MCks5q8eCygaJpZM4Krk9k.

ian898 commented 7 years ago

haha also I think I am going to reduce the size of the original weather icons as there a little distorted on the edges. If you can see in that image.

joskuijpers commented 7 years ago

Just use the original size, as it is in the top right ;)

On 09 Nov 2016, at 16:15, ian898 notifications@github.com wrote:

haha also I think I am going to reduce the size of the original weather icons as there a little distorted on the edges. If you can see in that image.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/theSeb1979/FS17_seasons/issues/12#issuecomment-259438164, or mute the thread https://github.com/notifications/unsubscribe-auth/AEyN0DL8aKQIjEG8fo9Yo3PjpJZNPcWwks5q8eOhgaJpZM4Krk9k.

ian898 commented 7 years ago

This is what I have after about 8 hours lol, The sun is place holder for the season icons.

I thins the temperature should be in the center under the weather icon, What do you guys think?

Also I know I wasn't exactly asked to do this and I hope I am not stepping on any toes.

fsscreen_2016_11_09_16_38_22

joskuijpers commented 7 years ago

Suggestions:

On 09 Nov 2016, at 17:42, ian898 notifications@github.com wrote:

This is what I have after about 6 hours lol, The sun is place holder for the season icons.

I thins the temperature should be in the center under the weather icon, What do you guys think?

Also I know I wasn't exactly asked to do this and I hope I am not stepping on any toes.

https://cloud.githubusercontent.com/assets/3869352/20146236/fbea0806-a69a-11e6-8527-b8b45aa8f130.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/theSeb1979/FS17_seasons/issues/12#issuecomment-259461491, or mute the thread https://github.com/notifications/unsubscribe-auth/AEyN0OLvPheJW_f_uZo8gtGRKzeF22gYks5q8ffpgaJpZM4Krk9k.

akuenzi commented 7 years ago

@ian898

This is what I have after about 8 hours lol, The sun is place holder for the season icons. I thins the temperature should be in the center under the weather icon, What do you guys think? Also I know I wasn't exactly asked to do this and I hope I am not stepping on any toes.

Nice work! I agree with joskuijpers -- we should at least try a smaller version, one the same size as in the upper right hand corner. His other suggestions are good, too. That's small enough, though, that it might not work to put the temperature information directly under the weather icon. On the other hand, if we make it that small, it might be hard to display the other stuff as well.

You're not stepping on any toes. The last I checked, this particular thread isn't "assigned," so have at it! :) I sympathize on the '8 hours' bit, though -- if someone told me at the beginning just how much time modding would take, I probably never would have even got started.

As for timing of all this... We can tweak the layout in here all we wish... but do you suppose we have enough to take this to Gary now? It seems we need at least 5 things from him: (1) Snow weather icon. (2) Summer season icon (to be distinct from the sunshine). (3) Winter season icon. (4) Autumn season icon. (5) Spring season icon.

If through the coding we're able to put these all in a row onscreen, like ian898 has shown, then we wouldn't need to trouble Gary with making anything on that... and have him focus solely on the icons. That said, I will try to 'leave the door open' with Gary to help with creating other stuff if needed.

I'll wait a few hours to hear back if anyone objects. Otherwise, I'll send it his way so he can be working on it.

theSeb1979 commented 7 years ago

Looking good. Yeah, the "squares" could be smaller and the text could be a little bit bigger. I know, I am being picky now. :D

ian898 commented 7 years ago

I am taking in all of what your saying I have messed around with size a fair bit I have in my mind that maybe we should leave some space for other thing later but I am so unsure, silly question this is set on a loop for each day to be rendered so how would I go about pulling values from a table? Ideally this table lol SeasonsUtil.weekDaysShort = {"Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun"};

@akuenzi

8 hours is a small number lol, All them icons would be good.

@theSeb1979

Seb Its fine I would rather you be picky now because I have console commands to change every part of layout text size position everything lol.

theSeb1979 commented 7 years ago

@ian898 , I would not waste your time on pulling out the proper text, or the actual forecast. I can easily do that. Focus on getting the graphics pretty. I don't think we will need to display much more in there. The only thing that I am thinking about is whether the day number in the bottom left corner should be days left in the season. But, again, that's an implementation detail that I, or somebody else, can easily implement. Looking at your last screenshot, I do think that all of the text could be a smidgeon bigger, especially since since it will only be a three letter word at the top. You could follow @joskuijpers 's advice literally and replace the text with a hard coded "MON", "TUE" etc to see how it will look. Or maybe "Mon" , " Tue" not sure if we want capitals, or not.

ian898 commented 7 years ago

I will enlarge the text and take a screenshot, I have also changed the DayName to "MON" as well.

ian898 commented 7 years ago

@theSeb1979

Are we happy with font size or we going bigger lol

fsscreen_2016_11_09_18_50_20

theSeb1979 commented 7 years ago

Text looks spot on, in my opinion. Is it possible squish down the squares into rectangles? It feels like there is a lot of black space around the icon.

ian898 commented 7 years ago

Yeah that's my next job I just wanted to get text the correct sizes before squishing it lol

akuenzi commented 7 years ago

@ian898 Oh no - Every day's a Monday! :)

Maybe it's just my eyes going cross-eyed in my old age, but is the icon just a wee bit off-center in each square? It seems like the cloud is hanging just a bit to the left. Not a huge deal, and I assume it can be adjusted later.

And you're right, 8 hours is a low number... and all these suggestions are just adding to it.

ian898 commented 7 years ago

I am glad my eye sight is just fine the cloud did need shifting lol.

Keep squishing? I think width could use some but height looks fine I think haha

I keep struggling with that day numbers in bottom right corner it just seems in the way lol

fsscreen_2016_11_09_19_13_00

ian898 commented 7 years ago

fsscreen_2016_11_09_19_31_45

joskuijpers commented 7 years ago

Awesome!

Some more:

Don’t forget to test with the other icons (try them all at same time) because they are not all the same size ;)

On 09 Nov 2016, at 20:32, ian898 notifications@github.com wrote:

https://cloud.githubusercontent.com/assets/3869352/20151737/31f197f8-a6b3-11e6-8786-57752a1552ea.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/theSeb1979/FS17_seasons/issues/12#issuecomment-259504146, or mute the thread https://github.com/notifications/unsubscribe-auth/AEyN0BWZ2muIgFwk0u2vtCSlpU8w0bhXks5q8h_YgaJpZM4Krk9k.

akuenzi commented 7 years ago

@ian898

I keep struggling with that day numbers in bottom right corner it just seems in the way lol

I see what you mean. What would happen if that number migrated 'upwards' a bit, and was just under the season icon? And should it be a different color, maybe matching whatever the color of the season icon is (yellow/orange in this case)?

ian898 commented 7 years ago

@joskuijpers

I will get to the background hud sorted them colours arre close but there not correct I just wanted to get placement sorted first. I will show you more of icons :D

@akuenzi

The text color can be implemented but I think I will wait for season huds before I do that.

Update Image: fsscreen_2016_11_09_20_44_13

joskuijpers commented 7 years ago

I think you shouldn’t show the day number. Or we should make the number only count to the NumDaysInSeason. Because a 1548 there doesn’t add anything functional. Looking good though!

Could you give making the season icon a bit smaller a try? (like, 2/3 of what it is now)

On 09 Nov 2016, at 21:49, ian898 notifications@github.com wrote:

@joskuijpers https://github.com/joskuijpers I will get to the background hud sorted them colours arre close but there not correct I just wanted to get placement sorted first. I will show you more of icons :D

@akuenzi https://github.com/akuenzi The text color can be implemented but I think I will wait for season huds before I do that.

Update Image: https://cloud.githubusercontent.com/assets/3869352/20154128/e1d83406-a6bd-11e6-8ccb-18d0bbc68adc.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/theSeb1979/FS17_seasons/issues/12#issuecomment-259522701, or mute the thread https://github.com/notifications/unsubscribe-auth/AEyN0OPIxt6SJPUyKjuO7l6D969_a1Blks5q8jHrgaJpZM4Krk9k.

ian898 commented 7 years ago

I think Seb was considering having it as a countdown of days left in the current season I see him mention it some were. I will give it a go making icon smaller.

akuenzi commented 7 years ago

@ian898 I agree -- this is good stuff. Thanks for being such a good sport and doing the real work here. :) And you're right -- Seb envisioned the number as counting down the # of days left in the season... which might be better than what my thought was, which was to count 'up' the # of days into each season, basically restarting at 1 when there's a new season. But maybe neither is needed... if we come up with another way to show the season's progress for the player somehow.

reallogger commented 7 years ago

You're doing some fantastic work here. Throwing in an idea here. Could a to a bar on top of the small squares indicate season?

alt text alt text

joskuijpers commented 7 years ago

There is already a season indicator (the icon in the top right of each. This might work too though

On 09 Nov 2016, at 22:22, reallogger notifications@github.com wrote:

You're doing some fantastic work here. Throwing in an idea here. Could a to a bar on top of the small squares indicate season?

https://camo.githubusercontent.com/44cb297d2fcfac51446999bc612dd0c9ac2994ca/68747470733a2f2f7075752e73682f73634e52312e6a7067 https://camo.githubusercontent.com/64009873c59438f5a0ab5a7b9a7e9c337f2049fd/68747470733a2f2f7075752e73682f73634e527a2e6a7067

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/theSeb1979/FS17_seasons/issues/12#issuecomment-259530205, or mute the thread https://github.com/notifications/unsubscribe-auth/AEyN0JmksLINMjF58J3A6ABbpYQEjXTCks5q8jl6gaJpZM4Krk9k.

akuenzi commented 7 years ago

Okay gents -- not hearing anything further on the icons, I'll send a message to Gary for the 5 items mentioned above, and we'll see what he comes up with as to 'new' stuff.

@reallogger I have to say I like the arrangement you've proposed as well. Maybe it's common to 'short-hand' things by using an icon, but the bar across the top and the related colors definitely look good.

ian898 commented 7 years ago

This is me done for the night I am happy with this result, but even still I would like some feedback lol

My brain needs sleep now lol.

fsscreen_2016_11_09_23_21_58

akuenzi commented 7 years ago

@ian898 Well done -- this is some excellent work! Wish I had your skills at doing this kind of graphical stuff.

joskuijpers commented 7 years ago

Looks good!!

On 10 Nov 2016, at 00:18, ian898 notifications@github.com wrote:

This is me done for the night I am happy with this result, but even still I would like some feedback lol

My brain needs sleep now lol.

https://cloud.githubusercontent.com/assets/3869352/20158534/bdf27f64-a6d2-11e6-8db8-dc14a0f731bd.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/theSeb1979/FS17_seasons/issues/12#issuecomment-259555040, or mute the thread https://github.com/notifications/unsubscribe-auth/AEyN0PXVvGhw7ez3OqTZaqx-sqxV8pPyks5q8lTagaJpZM4Krk9k.

ian898 commented 7 years ago

Im glad you think so haha, because my eyes say other wise so much precision to line them up as well as editing background lol.

P.s. I will clean up my code first thing in the morning and will add it on here.

ian898 commented 7 years ago

So fresh eyes and I get the feeling the white text could be dialled back a touch.

theSeb1979 commented 7 years ago

is it currently bold? It looks bold.

akuenzi commented 7 years ago

Guys -- take a look at this! I need to get myself to bed, but just had to show you this before I did. I was thinking it would take longer, but this is what Gary just sent me a little bit ago: capture Apologies -- the snow hud was in the middle of the seasonal huds when I took this screen capture... but to me it looks about perfect, and fits right in with the other weather huds. Do you suppose we should have him 'whiten' the snow, though? The rain is colored blue, maybe the snowflakes could be white versus the gray they are showing up as.

The seasonal icons speak for themselves. He said he hadn't added any color to them, but said he could do that if we wanted it. Personally, I think I'd like some color, though these look awesome just as they are. Some solid colors might make it stand out as being different from the weather huds a bit more... especially the sunshine icon. Maybe something like this?

Or... rather than coloring the season icon itself, should we leave the icon alone, and have him instead color the background of the icon? That'd definitely make it have a different look from the weather huds.

joskuijpers commented 7 years ago

This looks awesom!

No you cant color the background, that looks odd. I think coloring the icon is nice but we should ask a white set as well so we can try different things. Don't makenthe colors too complicated.

On Nov 10, 2016, at 10:34 AM, akuenzi notifications@github.com wrote:

Guys -- take a look at this! I need to get myself to bed, but just had to show you this before I did. I was thinking it would take longer, but this is what Gary just sent me a little bit ago:

Apologies -- the snow hud was in the middle of the seasonal huds when I took this screen capture... but to me it looks about perfect, and fits right in with the other weather huds. Do you suppose we should have him 'whiten' the snow, though? The rain is colored blue, maybe the snowflakes could be white versus the gray they are showing up as.

The seasonal icons speak for themselves. He said he hadn't added any color to them, but said he could do that if we wanted it. Personally, I think I'd like some color, though these look awesome just as they are. Some solid colors might make it stand out as being different from the weather huds a bit more... especially the sunshine icon. Maybe something like this?

Winter - Have the snowflake be white with a tinge of blue Spring - Add green for the stems, and maybe purple for the flower Summer - Hmm... this one might be tough. It's still a sun, but what other symbol of summer could we have. Maybe we could have him color it a dark orange-red... or even red itself... so as to set it apart from the sunny day weather hud color. Autumn - Some combination of light green, yellow, gold, and red on that maple leaf. Or... rather than coloring the season icon itself, should we leave the icon alone, and have him instead color the background of the icon? That'd definitely make it have a different look from the weather huds.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ian898 commented 7 years ago

@theSeb1979 It is bold yes should we try with out? As you can see from my last screen shot I made day number 2 digits to make sure there was enough room. @akuenzi Could you add them they look awesome and then I can factor them in to layout and then we can then edit the textures when ever then what size did you do them in after all? @joskuijpers I agree we should try everything at least once. :D

theSeb1979 commented 7 years ago

Yes, please Ian.

theSeb1979 commented 7 years ago

I have to say those icons look amazing

ian898 commented 7 years ago

@theSeb1979

I think I am going to wait until I have season icons and edit all the changes at once if thats ok.

theSeb1979 commented 7 years ago

Unacceptable.

joking. lol. sounds like a plan.

ian898 commented 7 years ago

Maybe this is more acceptable haha.

fsscreen_2016_11_10_12_28_30

joskuijpers commented 7 years ago

I like it but i think the temperatures can be a tiny bit smaller.

On 10 Nov 2016, at 13:29, ian898 notifications@github.com wrote:

Maybe this is more acceptable haha.

https://cloud.githubusercontent.com/assets/3869352/20176779/484aa236-a741-11e6-8008-4bf342413e30.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/theSeb1979/FS17_seasons/issues/12#issuecomment-259678123, or mute the thread https://github.com/notifications/unsubscribe-auth/AEyN0OnKHdwxom-hxdkq1b6UM6qnOFqKks5q8w4ugaJpZM4Krk9k.

ian898 commented 7 years ago

Its defiantly getting closer I was just looking through my screenshots of the whole process it kinda nice to see how its come along.

reallogger commented 7 years ago

Really like the work you are doing. Looks great.

Maybe a crazy idea again, but I throw it out here anyways. :)

In the Norwegian weather forecast there are something like 70-80 different symbols for the expected weather. http://om.yr.no/forklaring/symbol/

In FS there are symbols for cloudy, rain, hail, sun and partly clouded (or are there more?). With the development of the weather model it could be a possibility to differentiate between showers, light and heavy rain.

These are for instance the symbols for showers, light rain and heavy rain: imageimageimage

Too much or something that could be a nice feature?

akuenzi commented 7 years ago

Could you add them they look awesome and then I can factor them in to layout and then we can then edit the textures when ever then what size did you do them in after all?

I think I am going to wait until I have season icons and edit all the changes at once if thats ok.

Good morning gentlemen -- morning for me anyway. I suppose I should have done the above last night rather than showing a screen print. I'll need just a sec to figure out how to upload these. I'm still so new to github, and I was too excited to read all the instructions... so hopefully I'll figure it out and get it onto here.

@ian898 On the sizing, the huds should be exactly the same size as the ones you're working with: 128x128 And let me hasten to add that it wasn't me that did them, but Gary of FSModding.

ian898 commented 7 years ago

You should probably download github desktop it much easier to use. :)

Thanks for uploading these I can crack on now. :)

akuenzi commented 7 years ago

You should probably download github desktop it much easier to use.

Oh, I have github desktop... but that doesn't mean that this wazzock knows how to use it. 😝 I'm more afraid of screwing something up than anything else. Maybe the huds need to be in their own folder to stay tidy? I would have made an extra folder if I knew how. I'll figure it out eventually.

Thanks for uploading these I can crack on now. :)

Looking forward to seeing them in-game.

ian898 commented 7 years ago

This is all I use in github desktop lol.

You start by syncing the make your changes in explorer then you fill in summary submit commit to master then click sync and it will pull changes from github as well as pushing your changes.

github

joskuijpers commented 7 years ago

We cant differentiate between heavyness of rain (only the length). So what woul the icons do? What we CAN do is show some number that indicates the mm of water that will fall. (Length of rain)

On Nov 10, 2016, at 6:27 PM, ian898 notifications@github.com wrote:

This is all I use in github desktop lol.

Then you make the changes in explorer then you fill in summary submit commit to master then click sync and it will pull changes from github as well as pushing your changes.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.