search

RealismusModding / FS17_seasons

Farming Simulator 17 seasons mod
https://www.realismusmodding.com/mods/seasons
75 stars 55 forks source link

Make 'morning' time configurable #663

Closed fdanapfel closed 6 years ago

fdanapfel commented 6 years ago

With the latest version it is possible to choose between 'morning' and 'dawn' when using the 'Skip night' function. 'morning' seems to be hard-coded to 6:00.

Would there be a possibility to make the 'morning time configurable, e. g. that I can say morning should be 7:00 instead of 6:00?

joskuijpers commented 6 years ago

We will not be adding this as it is very opinionated. I chose 6AM because that is around the time many farmers get out of bed (at least around here).

On Nov 7, 2017, at 9:15 AM, Frank Danapfel notifications@github.com wrote:

With the latest version it is possible to choose between 'morning' and 'dawn' when using the 'Skip night' function. 'morning' seems to be hard-coded to 6:00.

Would there be a possibility to make the 'morning time configurable, e. g. that I can say morning should be 7:00 instead of 6:00?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

fdanapfel commented 6 years ago

Hmm, that's exactly why I suggest to make it configurable/chooseable, because everybody has its own opinion on what time morning is :)

6AM is far too early for me.

joskuijpers commented 6 years ago

Sadly, everyone has its own opinion on everything, and if we would make everything configurable it becomes a very big mess. So this is a no. Note that in Seasons 1.1, it always skipped to 6:00.

fdanapfel commented 6 years ago

OK, I'm not happy but I can live with that last explanation.

joskuijpers commented 6 years ago

If you want you can just change the code. Src/ssSkipNight.lua, on line 52 it says 660, turn it into 760 or 8*60 for 7AM or 8AM

On 10 Nov 2017, at 22:41, Frank Danapfel notifications@github.com wrote:

OK, I'm not happy but I can live with that last explanation.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/RealismusModding/FS17_seasons/issues/663#issuecomment-343594903, or mute the thread https://github.com/notifications/unsubscribe-auth/AEyN0HjP3LAHzu0c1HCOEQbqI8--wr7Qks5s1MMUgaJpZM4QUZ-w.