Growth issues - Githubissues

RealismusModding / FS17_seasons

Farming Simulator 17 seasons mod

https://www.realismusmodding.com/mods/seasons

75 stars 55 forks source link

Growth issues #732

Closed reallogger closed 6 years ago

reallogger commented 6 years ago

Since version 1.3 there has been several issues with growth. Two problems:

crops more or less randomly becomes harvestable 1 or more transitions too early
winter crops fail to germinate and turns to harvested in the beginning of spring

See following topics:


> I guess I am not understanding the growth right or something. I thought that grass grew at every transition

Isn't this just someone not understanding grass?


> -Base Seasons mod only-
> Planted corn (and soy) at start of summer (Day2)
> Whole corn crop died before end of summer
> 
> The only thing I can think of is ground temp dropped too low?
> Soybean runs at same temp, it survived.

https://forum.giants-software.com/viewtopic.php?f=893&t=112321&p=957420#p957218 Calendar changes over reloads


> I planted wheat, barley and canola on spring day 1. I am currently on summer day 2 and all of my crops are ready to be harvested and I have been able to successfully harvest them.

joskuijpers commented 6 years ago

Okay. for this I need a way to reproduce it. After that I can do debugging.

Any suggestions?

joskuijpers commented 6 years ago

More possible issues:


EDIT: He just screwed up the planting

If all of them are using SkipNight, the problem could be in there as well.

joskuijpers commented 6 years ago

Calendar has been fixed.

reallogger commented 6 years ago

Still one fix to be made by moving normalGrowth to after extraGrowth in GM. I propose to move L226-L229 to after current L235

theSeb1979 commented 6 years ago

Fine. I can do this tonight then

Sent from my iPhone

On 17 Jan 2018, at 14:38, reallogger notifications@github.com wrote:

Still one fix to be made by moving normalGrowth to after extraGrowth in GM. I propose to move L226-L229 to after current L235

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

joskuijpers commented 6 years ago

Will this break any existing GEOs? Or fix them? Does this need an update for GEOs on the PC side?

theSeb1979 commented 6 years ago

It will not break any existing stuff but it will fix some of the weird issues that are occasionally reported with certain geos. I foresee no changes required to any geos but will check them as well this week.

Sent from my iPhone

On 17 Jan 2018, at 14:45, Jos Kuijpers notifications@github.com wrote:

Will this break any existing GEOs? Or fix them? Does this need an update for GEOs on the PC side?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

reallogger commented 6 years ago

Won't break anything. It is just changing the order of how growth is applied. It will fix one small thing in the Midwest GEO and make the two new GEOs (Southern Australia and East Canada) work as they should.

joskuijpers commented 6 years ago

Can we release the two new GEOs in a way that works with the current (unchanged) model, for console?

reallogger commented 6 years ago

They won't break anything, but some crops will mature quicker than planned. I can assess the consequence and then we can make a decision based on that.

joskuijpers commented 6 years ago

Okay. What we could do is have a different version for console with changes so it is 'better', if needed.

joskuijpers commented 6 years ago

If the new GEOs can't work on 1.3, make sure to increment the simpleVersion with 1 in package.json and also update the seasons version in the GEO modDesc.xml. Then the GEO will not run on 1.3, but 1.3.1 only.

theSeb1979 commented 6 years ago

This can be closed now