search

RealistikOsu / USSR

Ultimate Score Server for RealistikOsu
GNU General Public License v3.0
18 stars 19 forks source link

Added folder requirements #10

Closed PANIGE closed 2 years ago

PANIGE commented 2 years ago

because automatically adding folders on deploying is always better than having errors and having to create them manually

RealistikDash commented 2 years ago

Hey! Thanks for the PR! This PR looks good and it fits the general code and organisation style we are going for. However, there is a small oversight (that doesn't need much to fix) in the folder checking and creation. The location of the .data directory is customisable within the config under the DATA_DIR option.

Ideally for the check, you'd want to check if that location exists first, and then if that location if populated with the correct folder structure.

PANIGE commented 2 years ago

Here it goes! thanks for the review, here is the fix for the folder to be configurable.