search

RealistikOsu / USSR

Ultimate Score Server for RealistikOsu
GNU General Public License v3.0
18 stars 19 forks source link

misc fixes #13

Closed cmyui closed 2 years ago

cmyui commented 2 years ago

felt like doing some code review to see how u guys have been progressing - here some stuff i found while going thru it

RealistikDash commented 2 years ago

Hey, cheers for the PR!

At quick glance, your PR looks well-made, making important and valid changes to the USSR codebase alongside rightfully displaying areas which deserve the most improvement and how to proceed. While the changes all look good, merging this PR requires testing on our end which should be done by tomorrow once our USSR dev environment is set up.