RealistikDash
commented
2 years ago Mostly done, however with two small issues are present:
- The personal best system currently has no sql portion implemented, meaning that pbs that are not in the top x scores are simply not fetched.
- Currently, there is a bug where new scores are inserted into the database correctly but do not appear on the cached leaderboards (meaning the score isnt inserted there correctly). From a small amount of testing, this occurs when a user already has a score on the map and that score is being replaced.
Edit 1: Confirmed the score not inserting into global lb to occur on a map where i did not have a previous best on, HOWEVER that map did have no scores prior.
Edit 2: Most likely maps where you didnt have a previous score are the main cause of this bug.
Edit 3: Solved all issues
Current leaderboards system is rather unflexible and honestly a giant mess. It may work phenomenally in prod (as experienced) but the code aspect could see some nice improvement. I believe a system similar to Acachesuki would be perfect.