search

RealityETH / subjectivocracy

Design and code prototypes for a system of forking oracle-enshrined L2 ledgers
26 stars 3 forks source link

Remove submodules except for the forge standard libraries and rely on npm #241

Closed edmundedgar closed 8 months ago

edmundedgar commented 8 months ago

This removes the need to have duplicate settings in package.json (for hardhat) and .gitmodules / remappings.txt (for forge) by making forge use the hardhat method. It also lets us use git submodules less which is good because they tend to confuse the hell out of everyone.

edmundedgar commented 8 months ago

The difference between v3.0.0-RealityETH just seems to be the package name etc, ie the version we're referencing in npm lacks this commit: https://github.com/RealityETH/zkevm-contracts/commit/c169730bc37328f52a91497dee0aba3983aff376

We want to manage this with a tag, right? (I think specifying the version one way or another would be the sane thing to do it's, less likely to cause trouble with caches and things). If so I can do another PR to tag the current main as v3.0.1-RealityETH and update to that.

Alternatively maybe we just pin the commit for the time being, rather than tagging every time, that would save us a step.