RealityETH / subjectivocracy

Design and code prototypes for a system of forking oracle-enshrined L2 ledgers
26 stars 3 forks source link

Can we reduce the changes to zkEVM etc? #270

Open edmundedgar opened 1 month ago

edmundedgar commented 1 month ago

May be related to #269

We made changes to zkEVM to make it forkable which then have to be audited. For better compatibility and to reduce the amount that has to be audited, it may be possible to run the stock zkEVM, although we probably still need to tinker with the bridges.

Something like:

josojo commented 1 month ago

Yeah, I checked when we used the onlyBeforeForking modifier and it seems to work as always the emergency is also checked.

It's nice that we reduce the diff... but I am not sure how much we are really winning by that. Since the interplay with the bridge needs to be audited anyways and generally the code would become harder to read.

I mean its not unreasonable to do, but it also not plain obvious that its better