Realizedd / TokenManager

An economy plugin for minecraft.
https://www.spigotmc.org/resources/tokenmanager.8610/
GNU General Public License v3.0
29 stars 47 forks source link

Name colors are not updating correctly. #26

Closed mibby closed 5 years ago

mibby commented 5 years ago

TokenManager 3.1.3 Paper dev 488 (Spigot 1.13.2)

@Realizedd Name colors don't seem to be updating correctly. Possibly a 1.13 issue?

      '4':
        displayed: TRIPWIRE_HOOK 1 unbreaking:10 flags:HIDE_UNBREAKABLE,HIDE_ATTRIBUTES,HIDE_ENCHANTS name:&f&lSuit_&6&lCrate_Key lore:&dCost:&a_%price%_Tokens
        cost: 40
        message: '&b&lToken &f&l» &7Purchase completed, %player%! &c-%price% tokens'
        commands:
        - 'cr give to %player% SuitCrate 1'

link

Should be white and bolded, not blue and italicized.

Realizedd commented 5 years ago

https://www.spigotmc.org/threads/featherboard-incorrect-colorcodes.336783/#post-3136650

May be related to this. Are you running any sort of protocol hack?

mibby commented 5 years ago

I use ProtocolSupport for older version compatibility. Not sure if you consider protocollib a protocol hack, don't use any of the viaversion plugins either.

This is a 1.13.2 server displaying on a 1.13.2 client though. I don't believe ProtocolSupport touches the initial coloring. There was a bug with 1.13 initially with items being italicized. Though I don't know if it affected containers or if it was ever fixed.

https://bugs.mojang.com/browse/MC-124458 https://bugs.mojang.com/browse/MC-128958

I'll try removing ProtocolSupport later tomorrow to see if it resolves itself.

Realizedd commented 5 years ago

Any updates?

mibby commented 5 years ago

@Realizedd Unfortunately even with ProtocolSupport removed, the random italic and color with 1.13 is still there.

Tested with TokenShop 3.2.0 on Paper dev 489 (Spigot 1.13.2).

Here is my shop config as reference. https://paste.ubuntu.com/p/XJ9CkW5pRs/

Realizedd commented 5 years ago

https://github.com/PaperMC/Paper/issues/1484

Apparently spigot now removes the white color code if it's found first in line. For a fix, you can use &r instead of &f.

mibby commented 5 years ago

How weird. Using &r does seem to work around the issue though, thanks!